Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [popover] default trigger #12321

Merged
merged 1 commit into from
Apr 6, 2023
Merged

fix(components): [popover] default trigger #12321

merged 1 commit into from
Apr 6, 2023

Conversation

MrWeilian
Copy link
Contributor

fix: #12312

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @MrWeilian, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023 •
edited

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Hello @MrWeilian, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

🧪 Playground Preview: https://element-plus.run/?pr=12321
Please comment the example via this playground if needed.

@MrWeilian
Copy link
Contributor Author

playground

btea
btea approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have collected a nice pr number 😄

@MrWeilian
Copy link
Contributor Author

😁 lucky

ryuhangyeong
ryuhangyeong approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@ryuhangyeong ryuhangyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrWeilian LGTM

@ryuhangyeong ryuhangyeong merged commit bda7d9a into element-plus:dev Apr 6, 2023
11 checks passed
chenxch added a commit that referenced this pull request Apr 6, 2023
@chenxch
Revert "fix(components): [popover] default trigger (#12321)"
ce76bdc 
This reverts commit bda7d9a.
@chenxch chenxch mentioned this pull request Apr 6, 2023
Merged
chenxch added a commit that referenced this pull request Apr 6, 2023
@chenxch
Revert "fix(components): [popover] default trigger" (#12341)
c4fcb15 
Revert "fix(components): [popover] default trigger (#12321)"

This reverts commit bda7d9a.
@element-bot element-bot mentioned this pull request Apr 7, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
@MrWeilian @consultation-applio
fix(components): [popover] default trigger (element-plus#12321)
6107b33
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
@chenxch @consultation-applio
Revert "fix(components): [popover] default trigger" (element-plus#12341)
40acd01 
Revert "fix(components): [popover] default trigger (element-plus#12321)"

This reverts commit bda7d9a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@MrWeilian MrWeilian

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [popover] Popover default trigger has changed from click to hover
4 participants
@MrWeilian @tolking @btea @ryuhangyeong