Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(components): [popover] default trigger" #12341

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Revert "fix(components): [popover] default trigger" #12341

merged 1 commit into from
Apr 6, 2023

Conversation

chenxch
Copy link
Member

@chenxch chenxch commented Apr 6, 2023

Reverts #12321

@github-actions
Copy link

github-actions bot commented Apr 6, 2023 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Apr 6, 2023
@ryuhangyeong
Copy link
Member

@chenxch Is there a problem with that code? 🤔

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🧪 Playground Preview: https://element-plus.run/?pr=12341
Please comment the example via this playground if needed.

@chenxch
Copy link
Member Author

chenxch commented Apr 6, 2023

@chenxch Is there a problem with that code? 🤔

The default trigger method of popover should be hover, not click.

@btea
Copy link
Collaborator

btea commented Apr 6, 2023

If so, this revert should be merged with #12342.

@MrWeilian
Copy link
Contributor

😅 unlucky

@chenxch
Copy link
Member Author

chenxch commented Apr 6, 2023

😅 unlucky

Don't worry, luck will favor everyone who really loves open source.😬

@chenxch chenxch merged commit c4fcb15 into dev Apr 6, 2023
11 checks passed
@chenxch chenxch deleted the revert-12321-fix/popover-default-trigger branch April 6, 2023 14:17
@MrWeilian
Copy link
Contributor

😬hhh. I found that element-ui default trigger is "click" !

@chenxch
Copy link
Member Author

chenxch commented Apr 7, 2023 •
edited

😬hhh. I found that element-ui default trigger is "click" !

Yes, but we have compared the practices of several mainstream warehouses with hover by default.

@element-bot element-bot mentioned this pull request Apr 7, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
@chenxch @consultation-applio
Revert "fix(components): [popover] default trigger" (element-plus#12341)
40acd01 
Revert "fix(components): [popover] default trigger (element-plus#12321)"

This reverts commit bda7d9a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plainheart plainheart plainheart approved these changes

Assignees

@chenxch chenxch

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chenxch @ryuhangyeong @btea @MrWeilian @plainheart