Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [sub-menu] style error in collapsed state #13135

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix(components): [sub-menu] style error in collapsed state #13135

merged 2 commits into from
Oct 13, 2023

Conversation

Lucky-Ya-Q
Copy link
Contributor

@Lucky-Ya-Q Lucky-Ya-Q commented Jun 8, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at ead0fe3

Improve menu item styling in theme-chalk. Adjust menu.scss to account for submenu icons.

Related Issue

Fixes #13133.

Explanation of Changes

🤖 Generated by Copilot at ead0fe3

  • Add padding-right to menu item label with submenu icon to align with icon and prevent overlap (link)
  • Remove padding-right from menu item label without submenu icon to avoid extra space (link)

@pull-request-triage
Copy link

👋 @Lucky-Ya-Q, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Hello @Lucky-Ya-Q, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

🧪 Playground Preview: https://element-plus.run/?pr=13135
Please comment the example via this playground if needed.

@tolking
Copy link
Member

tolking commented Aug 22, 2023

@chenxch @ryuhangyeong cc

@tolking tolking merged commit 10fb223 into element-plus:dev Oct 13, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Oct 13, 2023
3 tasks
cc-hearts pushed a commit to cc-hearts/element-plus that referenced this pull request Oct 15, 2023
…lus#13135)

* fix(components): [sub-menu] style error in collapsed state

* fix(theme-chalk): [menu] optimize

---------

Co-authored-by: tolking <qw13131wang@gmail.com>
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
…lus#13135)

* fix(components): [sub-menu] style error in collapsed state

* fix(theme-chalk): [menu] optimize

---------

Co-authored-by: tolking <qw13131wang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] [sub-menu] 折叠状态下,鼠标移到 sub-menu 后,menu 右侧边框被遮挡
4 participants