Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [menu] remove excess inline styles #13693

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix(components): [menu] remove excess inline styles #13693

merged 2 commits into from
Oct 13, 2023

Conversation

tolking
Copy link
Member

@tolking tolking commented Jul 21, 2023 •
edited

before

after

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 9fff23e

Refactored sub-menu component to use hooks and simplify code.

Related Issue

Fixes #13685.

Explanation of Changes

🤖 Generated by Copilot at 9fff23e

  • Replace the computed properties for menu colors and title style with custom hooks for better reactivity and consistency (link, link, link, link)
  • Remove the unused CSSProperties type import from sub-menu.ts (link)

@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jul 21, 2023
@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=13693
Please comment the example via this playground if needed.

@makedopamine
Copy link
Contributor

The el-sub-menu and the el-menu-item are slightly different when hovering over them.
image

@tolking
Copy link
Member Author

tolking commented Jul 25, 2023

The el-sub-menu and the el-menu-item are slightly different when hovering over them. image

This issue will be fixed through #13135

@tolking tolking merged commit 7f375f0 into dev Oct 13, 2023
10 checks passed
@tolking tolking deleted the style/sub-menu branch October 13, 2023 02:37
@element-bot element-bot mentioned this pull request Oct 13, 2023
Merged
3 tasks
cc-hearts pushed a commit to cc-hearts/element-plus that referenced this pull request Oct 15, 2023
@tolking @cc-hearts
fix(components): [menu] remove excess inline styles (element-plus#13693)
075753a 
* fix(components): [menu] remove excess inline styles

* fix(theme-chalk): [menu] fix styles
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@tolking @dannyhebertbell
fix(components): [menu] remove excess inline styles (element-plus#13693)
d33695a 
* fix(components): [menu] remove excess inline styles

* fix(theme-chalk): [menu] fix styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch approved these changes

Assignees

@tolking tolking

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Style] [menu, sub-menu] 深色菜单折叠后子菜单多出一像素
3 participants
@tolking @makedopamine @chenxch