Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [date-picker] month range should emit calendar-change #14262

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

Justineo
Copy link
Contributor

@Justineo Justineo commented Sep 12, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

This PR is a complement to #13880 (which is blocked at the moment).

🤖 Generated by Copilot at 0b7d25b

Added calendar-change event to panel-month-range.vue component and updated the documentation. This event allows users to get the selected min and max dates when they change the calendar view in the monthrange and yearrange panels.

Related Issue

Fixes #13835.

Related Discussions:

Explanation of Changes

🤖 Generated by Copilot at 0b7d25b

  • Add calendar-change event to panel-month-range.vue component to emit selected min and max dates as an array when calendar view changes (link, link)
  • Update description of calendar-change event in date-picker.md documentation to reflect that it is also emitted by monthrange and yearrange panels (link)

@pull-request-triage
Copy link

👋 @Justineo, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Sep 12, 2023
@github-actions
Copy link

github-actions bot commented Sep 12, 2023

@github-actions
Copy link

Hello @Justineo, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14262
Please comment the example via this playground if needed.

Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea merged commit 6e24736 into element-plus:dev Sep 13, 2023
13 checks passed
@Justineo Justineo deleted the month-range-change branch September 13, 2023 09:33
@element-bot element-bot mentioned this pull request Sep 14, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [date-picker] Datepicker did not trigger calendar-change when type is monthrange
3 participants