fix(components): [table] fix summary row cells on table with layout auto not aligned with data cells #14315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @FrontEndDog, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
|
Hello @FrontEndDog, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
|
🧪 Playground Preview: https://element-plus.run/?pr=14315 |
tolking
approved these changes
Sep 30, 2023
This was referenced Oct 12, 2023
cc-hearts
pushed a commit
to cc-hearts/element-plus
that referenced
this pull request
Oct 15, 2023
…uto not aligned with data cells (element-plus#14315) fix(components): [table] fix summary row cells not aligned
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
…uto not aligned with data cells (element-plus#14315) fix(components): [table] fix summary row cells not aligned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
Change the
table-footerto the same structure as thetable-headerRelated Issue
Fixes #14306 .
Explanation of Changes
🤖 Generated by Copilot at b2c4942
table-footercomponent to usetfootelement and remove unused imports and variables (link, link, link)table-footercomponent totablecomponent template and conditionally render it based onshowSummaryandtableLayoutprops (link, link)table-footercomponent insidetableelement infooterWrapperdiv and renderhColgroupcomponent to align column widths and spans (link)tfootelement with consistent background and text color and remove unnecessary border and overflow styles fromfooter-wrapperelement (link, link, link)