Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [table] show-summary style error when table-layout=auto #14523

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

tolking
Copy link
Member

@tolking tolking commented Oct 12, 2023

It is an enhancement for #14315, same like #11742.

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at fcce49e

This pull request enhances the table component by making the footer sticky when the table is vertically scrollable. It modifies the table.vue and table.scss files to implement this feature.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at fcce49e

  • Add scrollable-y class to table element when height exceeds available space (link)
  • Apply sticky positioning and z-index to table body header and footer elements when scrollable-y class is present (link)
  • Prevent table footer wrapper element from overflowing or shrinking when table is scrollable vertically (link)
  • Use el-table__body-footer class to target table body footer element in packages/theme-chalk/src/table.scss (link,link)

@github-actions
Copy link

github-actions bot commented Oct 12, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 12, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14523
Please comment the example via this playground if needed.

@tolking tolking merged commit 942284d into dev Oct 12, 2023
13 checks passed
@tolking tolking deleted the fix/table-auto-show-summary branch October 12, 2023 13:46
@element-bot element-bot mentioned this pull request Oct 13, 2023
3 tasks
cc-hearts pushed a commit to cc-hearts/element-plus that referenced this pull request Oct 15, 2023
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants