-
-
Notifications
You must be signed in to change notification settings - Fork 16.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [tabs] optimize SSR #15183
Conversation
👋 @makedopamine, thank you for contributing element-plus. |
Hello @makedopamine, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
🧪 Playground Preview: https://element-plus.run/?pr=15183 |
cb56200
to
437cc97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@tolking Looking forward to seeing the update merge. Any idea when it will be pushed? |
There are code conflicts that need to be resolved. |
437cc97
to
a5c62f9
Compare
Resolved |
? [header, panels] | ||
: [panels, header]} | ||
{panels} | ||
{header} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tab-position value is top
by default, that is, the header in the upper panels in the lower, why do we default the header in the lower, and then use flex-direction: column-reverse
to go to the inverse again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason had been mentioned in the above comment.
这个PR是属于breaking chang,所以才会在v2.8.0 合并。 对于普通用户来说影响应该挺小的。 |
也许我们应该在changelog中体现这些变更的细节。 |
@zhixiaotong 多谢反馈,后续我们会尝试优化这方面的工作。 |
fixes #15088
before
after