Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(components): [select] add width change description #16268

Merged
merged 2 commits into from
Mar 27, 2024
Merged

docs(components): [select] add width change description #16268

merged 2 commits into from
Mar 27, 2024

Conversation

btea
Copy link
Collaborator

@btea btea commented Mar 27, 2024 •
edited
Loading

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

The issue with width changes seems to affect a lot of people, and it might be friendlier to add a note at the top of the page.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Mar 27, 2024
@btea btea requested a review from kooriookami March 27, 2024 07:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=16268
Please comment the example via this playground if needed.

@btea @kooriookami
Update docs/en-US/component/select.md
cfaf784 
Co-authored-by: kooriookami <38392315+kooriookami@users.noreply.github.com>
@kooriookami
Copy link
Member

Do we need two tips?
image

@btea
Copy link
Collaborator Author

btea commented Mar 27, 2024

Needed, these are instructions for two different scenarios.

@kooriookami
Copy link
Member

OK~

@kooriookami kooriookami merged commit fa91edd into dev Mar 27, 2024
8 checks passed
@kooriookami kooriookami deleted the docs/select-add-tip branch March 27, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kooriookami kooriookami kooriookami approved these changes

Assignees

@btea btea

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btea @kooriookami