Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): dialog zIndex 修改不生效 #16359

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

ydaydayup
Copy link

closed #16329

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Copy link

👋 @ydaydayup, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

Copy link

github-actions bot commented Apr 1, 2024

Hello @ydaydayup, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

🧪 Playground Preview: https://element-plus.run/?pr=16359
Please comment the example via this playground if needed.

@@ -162,7 +162,6 @@ export const useDialog = (
closed.value = false
open()
rendered.value = true // enables lazy rendering
zIndex.value = isUndefined(props.zIndex) ? nextZIndex() : zIndex.value++
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看上去没有在打开前对 ZIndex 赋值会存在问题

步骤

  • 对一个弹窗执行打开关闭几次
  • 在弹窗打开状态时,打开另一个弹窗
  • 另一个弹窗被之前的弹窗覆盖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [dialog] dialog zIndex动态修改的情况下无效
2 participants