Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [table-v2] 新增border属性 #16710

Closed
wants to merge 2 commits into from
Closed

feat(components): [table-v2] 新增border属性 #16710

wants to merge 2 commits into from

Conversation

makai1027
Copy link

Please make sure these boxes are checked before submitting your PR, thank you!

  • [✅ ] Make sure you follow contributing guide English | (中文 | Español | Français).
  • [✅ ] Make sure you are merging your commits to dev branch.
  • [ ✅] Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @makai1027, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Apr 29, 2024
@github-actions GitHub Actions
Copy link

@github-actions GitHub Actions
Copy link

Hello @makai1027, thank you for contributing to element-plus, please see our guideline to see how to make contribution

warmthsea
warmthsea reviewed Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@warmthsea warmthsea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supplementary documentation, instructions and testing would be a better PR.

@makai1027
Copy link
Author

Supplementary documentation, instructions and testing would be a better PR.

Ok，I'll get it.

@makai1027 makai1027 closed this Apr 29, 2024
@NicCraver
Copy link

加油 等你的代码发版 @makai1027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmthsea warmthsea warmthsea left review comments

Assignees

@makai1027 makai1027

Labels
1st contribution Their very first contribution Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makai1027 @NicCraver @warmthsea