-
-
Notifications
You must be signed in to change notification settings - Fork 16.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): [form] add getFieldsValue method #16739
Conversation
👋 @Liao-js, thank you for contributing element-plus. |
🧪 Playground Preview: https://element-plus.run/?pr=16739 |
The functions of this PR overlap with those discussed in #16747. Directly exporting fields will give users more room to operate. |
ok, what do you need me to do? |
directly exporting fields will give users more room to operate,but I think this does not conflict with pr. The functions is more suitable for users who use dynamic forms. It can facilitate users to directly obtain the value of the corresponding structure for direct submission without additional processing of propString. |
@tolking Do you think this new method in PR is necessary? IMO, it should be enough to directly export |
Yes, you have a point. But this is the first time I've seen a need in this area, and this method doesn't seem to be used frequently. I don't know if we should add it, maybe more people should be consulted. |
IMO, It would be better for users to implement this special requirement by themselves. The newly added code may be redundant for most people. |
IMO, This method leans more towards the business level, Not every user needs to submit data of type 'Record<string, any>', It may also be of other types, such as 在我看来,这个方法更偏向于业务层面,并不是每个用户所需要提交的数据都是 |
I agree with your point of view, I did not consider it comprehensively enough.I will close this PR. |
fix #16719
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.