Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [tree] add missing type reject for LoadFunction #16990

Merged

Conversation

kaedeair
Copy link
Contributor

@kaedeair kaedeair commented May 26, 2024

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

修复了Tree组件懒加载方法中reject函数的类型缺失问题 #16099

Copy link

👋 @kaedeair, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels May 26, 2024
Copy link

github-actions bot commented May 26, 2024

Copy link

Hello @kaedeair, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@kaedeair
Copy link
Contributor Author

kaedeair commented May 31, 2024

It causes build fail using typescript while linting strict on
Playground

Type '(node: Node, resovle: (data: Tree[]) => void, reject: () => void) => void' is not assignable to type 'LoadFunction'. Target signature provides too few arguments. Expected 3 or more, but got 2.ts(2322)

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 26, 2024
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea requested review from tolking and kooriookami June 26, 2024 09:40
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=16990
Please comment the example via this playground if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants