-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractAppContainer: Use ProgressButton #1708
Conversation
This appears to work as well as the progress_bar in master with the fixes noted above. There are probably ways it could be improved, though. |
From a design perspective, this looks good to me. I'm +1 on having the details in a tooltip Probably does need a little |
@danrabbit alright, RTL is handled and I pulled the non-changing CSS out into a GResource so we're only changing the one line. Looks and behaves the same as before (with the addition of RTL support). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this in the various views and it looks good and works as expected. Fixes the issues with the progressbar in the layout. Nice work!
This adds a progress bar to the button instead of packing a whole Gtk.ProgressBar. As a result, the UI doesn't resize. Fixes #1653, fixes #1698.
I initially investigated using a Dazzle.ProgressButton, but in testing, it wasn't styled correctly (and it seemed overkill to add Dazzle as a dependency for something relatively simple). Instead, this branch makes a new simple ProgressButton using a similar approach to that of Dazzle.ProgressButton.
@accent_color
or something else