Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpak Runtimes #1956

Merged
merged 5 commits into from Dec 20, 2022
Merged

Flatpak Runtimes #1956

merged 5 commits into from Dec 20, 2022

Conversation

meisenzahl
Copy link
Member

@meisenzahl meisenzahl commented Dec 20, 2022

Fixes #1786

In preparation for #1943 and potentially for elementary/os#582, I propose that we remove updates for Flatpak Runtimes from the "Operating System Updates" category and group them in the new "Runtime Updates" category.

This would have the advantage that "Operating System Updates" would only be managed by PackageKit. This would simplify handling and presentation for #1943.

Before After

To test the changes, you can downgrade io.elementary.Platform/x86_64/7.1:

sudo flatpak update \
    --commit=995cc9d6c6b1ea57a4869bc4e59a7d325750899a24a1dc1043438d7e840ca466 \
    io.elementary.Platform/x86_64/7.1

@meisenzahl
Copy link
Member Author

application-x-sharedlib probably is a better choice:

@meisenzahl
Copy link
Member Author

I was not aware of application-vnd.flatpak:

@danirabbit
Copy link
Member

Makes sense to me! I'm +1 on the Flatpak bundle icon. Nice work :)

@danirabbit
Copy link
Member

Actually thinking about it, since there's unlikely to be more than a handful of runtime updates, do we really need to group them? I think the original idea behind grouping OS Updates was because there could easily be like a dozen or more of them at a time and they're all very cryptic and don't have appdata etc. but Flatpak runtimes should have appstream data and you probably will only ever see a couple of them at a time

@meisenzahl
Copy link
Member Author

@danirabbit I will prepare an alternative PR without grouping.

@Marukesu
Copy link

Actually thinking about it, since there's unlikely to be more than a handful of runtime updates, do we really need to group them? I think the original idea behind grouping OS Updates was because there could easily be like a dozen or more of them at a time and they're all very cryptic and don't have appdata etc. but Flatpak runtimes should have appstream data and you probably will only ever see a couple of them at a time

Flatpak extensions are runtimes too, and most of, if not all, don't ship with metainfo. we should be sure that we can export metainfo files for at least .Locale and .Debug extensions (since those are generated automatically by flatpak-bulder, instead of by alternatives manifest) and recommend that for third-party applications.

however, metainfos aren't required for runtimes and extensions in flatpak-builder, external repos still can have them and we would need to have a way to show them here as we have with apt packages.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, let's go ahead with this branch so we can unblock @meisenzahl and we can always revisit it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show flatpak runtimes as system updates
3 participants