Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty output Flatpak package origins #1962

Merged
merged 3 commits into from Dec 29, 2022
Merged

Pretty output Flatpak package origins #1962

merged 3 commits into from Dec 29, 2022

Conversation

meisenzahl
Copy link
Member

@meisenzahl meisenzahl commented Dec 29, 2022 •
edited

Closes #1310

Before

After

@meisenzahl meisenzahl requested a review from a team December 29, 2022 12:33
@danirabbit
Copy link
Member

Did we already try getting the title as in #1310? It sounds like there's a user-facing remote title string we should be using that we don't have to hard code

@meisenzahl
Copy link
Member Author

@danirabbit thanks for mentioning #1310 :)

danirabbit
danirabbit approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Works as expected here. Fallbacks look good. And no hardcoding :)

@danirabbit danirabbit merged commit 089144d into master Dec 29, 2022
@danirabbit danirabbit deleted the pretty-output-flatpak-package-origins branch December 29, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get Flatpak remote names from Title field
2 participants
@meisenzahl @danirabbit