Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meson options to disable backends #1994

Merged
merged 12 commits into from May 18, 2023
Merged

Add meson options to disable backends #1994

merged 12 commits into from May 18, 2023

Conversation

meisenzahl
Copy link
Member

Closes #1076

@meisenzahl
Copy link
Member Author

@sysrich had expressed interest at GUADEC in using a Flatpak-only AppCenter for a project he was working on. It could be useful to provide a flag to disable the PackageKit backend and only talk to Flatpak.

@sysrich if you're still interested. Great talk at FOSDEM by the way :)

@meisenzahl meisenzahl requested a review from a team February 7, 2023 11:23
@danirabbit danirabbit added this to In progress in Distro-agnostic Pantheon via automation Feb 7, 2023
meisenzahl
meisenzahl commented Mar 13, 2023
View reviewed changes
src/Core/Package.vala Outdated Show resolved Hide resolved
zeebok
zeebok requested changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but there is a conflict with master to tackle first

@sysrich
Copy link

sysrich commented Mar 20, 2023

I'm interested.. I've packaged gnome-software to behave like this but once this gets merged I'd see which does the job better :)

@meisenzahl meisenzahl requested a review from zeebok May 16, 2023 13:17
zeebok
zeebok approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one question for clarification, otherwise it seems good

src/meson.build Show resolved Hide resolved
@meisenzahl meisenzahl merged commit d49be61 into master May 18, 2023
4 checks passed
@meisenzahl meisenzahl deleted the backend-flags branch May 18, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Distro-agnostic Pantheon
Status: Done
Distro-agnostic Pantheon
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flag for Flatpak-only
3 participants
@meisenzahl @sysrich @zeebok