Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Web 40 #41

Merged
merged 10 commits into from
Oct 26, 2021
Merged

Update to Web 40 #41

merged 10 commits into from
Oct 26, 2021

Conversation

cassidyjames
Copy link
Contributor

@cassidyjames cassidyjames commented Aug 16, 2021

Fix #30

Screenshot from 2021-08-16 16-33-17

@davidmhewitt
Copy link
Member

davidmhewitt commented Sep 18, 2021

I've pushed a temporary commit to build the stylesheet from my branch so people can hack on that to fix the tab styling, current progress looks like this:

Screenshot from 2021-09-18 17 09 09@2x

There's still an issue with the first tab or first pinned tab not having its left border and the new tab button could probably use some positioning work:

image

Feel free to hack on my stylesheet branch in elementary/stylesheet#1089

@danirabbit
Copy link
Member

This ended up taking a lot more than I thought, so I made a branch here: elementary/stylesheet#1095

And I bumped this yml to build against that for testing

The close button position thing I'm not sure the source of. This is supposed to be working automatically already. Poked Alex about it in Slack

@cassidyjames
Copy link
Contributor Author

@danrabbit it sounded like it was discovered to be an issue upstream. Do we consider that a blocker, do we want to patch it downstream for now, or do we get this in and be fine with the close button moving until the next release? 😅

@danirabbit
Copy link
Member

@cassidyjames It probably shouldn't be too hard to carry a the patch downstream for now. I can look at it when power comes back on ;p

@cassidyjames
Copy link
Contributor Author

@danrabbit looks like the fix is in master upstream: https://gitlab.gnome.org/GNOME/epiphany/-/commit/6e9d6d3cf7fa7ddf21a70e9816a5cd4767a79523

@danirabbit
Copy link
Member

I guess the only other thing here is I can't seem to figure out where Firefox sync went?

@cassidyjames
Copy link
Contributor Author

@danrabbit it's in the bookmarks menu instead of settings, which makes some sense to me.

@danirabbit
Copy link
Member

Cool, then I think this is good to go once we get the new runtime published 🎉

@danirabbit
Copy link
Member

New platform just dropped, let's fucking go 🚀

@danirabbit danirabbit marked this pull request as ready for review October 26, 2021 19:46
danirabbit
danirabbit previously approved these changes Oct 26, 2021
@Marukesu
Copy link

I believe we want to remove the AccountsService access here too, now that it's using the portal

@danirabbit danirabbit dismissed their stale review October 26, 2021 20:03

also testing dark style settings

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright just confirmed it works as expected. Go team!

@danirabbit danirabbit merged commit cc17559 into main Oct 26, 2021
@danirabbit danirabbit deleted the manifest-40.3 branch October 26, 2021 20:21
bobby285271 added a commit to bobby285271/nixpkgs that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out of date from upstream (3.38 vs 40.0)
4 participants