-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Web 40 #41
Update to Web 40 #41
Conversation
I've pushed a temporary commit to build the stylesheet from my branch so people can hack on that to fix the tab styling, current progress looks like this: There's still an issue with the first tab or first pinned tab not having its left border and the new tab button could probably use some positioning work: Feel free to hack on my stylesheet branch in elementary/stylesheet#1089 |
This ended up taking a lot more than I thought, so I made a branch here: elementary/stylesheet#1095 And I bumped this yml to build against that for testing The close button position thing I'm not sure the source of. This is supposed to be working automatically already. Poked Alex about it in Slack |
@danrabbit it sounded like it was discovered to be an issue upstream. Do we consider that a blocker, do we want to patch it downstream for now, or do we get this in and be fine with the close button moving until the next release? 😅 |
@cassidyjames It probably shouldn't be too hard to carry a the patch downstream for now. I can look at it when power comes back on ;p |
@danrabbit looks like the fix is in master upstream: https://gitlab.gnome.org/GNOME/epiphany/-/commit/6e9d6d3cf7fa7ddf21a70e9816a5cd4767a79523 |
I guess the only other thing here is I can't seem to figure out where Firefox sync went? |
@danrabbit it's in the bookmarks menu instead of settings, which makes some sense to me. |
Cool, then I think this is good to go once we get the new runtime published 🎉 |
New platform just dropped, let's fucking go 🚀 |
I believe we want to remove the AccountsService access here too, now that it's using the portal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright just confirmed it works as expected. Go team!
Fix #30