Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Window Prompt #207

Merged
merged 6 commits into from
Oct 21, 2021
Merged

Added New Window Prompt #207

merged 6 commits into from
Oct 21, 2021

Conversation

rakshit087
Copy link
Contributor

Fixes #155

Edited the desktop file to add a 'New Window' prompt when user right clicks.

@jeremypw
Copy link
Collaborator

As a hint, its better to create a new branch on your fork and modify that.

@rakshit087
Copy link
Contributor Author

Okay I will create a new branch, or shall I remove %U in both the execution commands?

@jeremypw
Copy link
Collaborator

Okay I will create a new branch, or shall I remove %U in both the execution commands?

I am just checking that everything works in Flatpak when those parameters are removed. Calculator is a bit unusual - most elementary apps are singletons by default and you have to apply an option in order for a new window to open. However, its best not to allow mission drift for one PR. If other changes that are not essential to this PR are desired they should be made in another PR.

@rakshit087
Copy link
Contributor Author

rakshit087 commented Oct 18, 2021

Okay! Let me know if everything works if those parameters are removed, I will make the necessary changes 😁

PS: I am actually new to open-source space, so I don't know how can I change the branch of this push request. I will do so after learning about it 😅

@jeremypw
Copy link
Collaborator

I have now confirmed that installing as a Flatpak with the %U removed both in Exec and in the NewWindow action works OK. The new action appears in the dock and in the Applications Menu as expected. So in this case I think we can fix both issues at once - thanks!

@rakshit087
Copy link
Contributor Author

rakshit087 commented Oct 18, 2021

Wow! Thank you so much will make a new commit in a min.
Commited :))

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now - but just remembered that you should update the appdata release information when changes significantly impact the UX.

@jeremypw jeremypw mentioned this pull request Oct 20, 2021
@rakshit087
Copy link
Contributor Author

rakshit087 commented Oct 20, 2021

Okay! How can I do so? Sorry I am kind of new to opensource and stuff. Shall I make it 1.7.1?

@jeremypw
Copy link
Collaborator

jeremypw commented Oct 20, 2021

You need to edit /data/io.elementary.calculator.appdata.xml.in and add another <li></li> entry to release 1.7.1.

Something like <li>Add New Window Desktop Action</li>

@rakshit087
Copy link
Contributor Author

Got it, working on it

@rakshit087
Copy link
Contributor Author

Done 👍

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go - thanks!

@jeremypw jeremypw enabled auto-merge (squash) October 21, 2021 12:19
@jeremypw jeremypw merged commit 502de1a into elementary:master Oct 21, 2021
@rakshit087
Copy link
Contributor Author

As a hint, its better to create a new branch on your fork and modify that.

I finally understand this. Will keep this in mind when I make a PR next time 👍
Thank you for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "New Window" action to the Desktop file.
2 participants