-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added New Window Prompt #207
Conversation
As a hint, its better to create a new branch on your fork and modify that. |
Okay I will create a new branch, or shall I remove %U in both the execution commands? |
I am just checking that everything works in Flatpak when those parameters are removed. Calculator is a bit unusual - most elementary apps are singletons by default and you have to apply an option in order for a new window to open. However, its best not to allow mission drift for one PR. If other changes that are not essential to this PR are desired they should be made in another PR. |
Okay! Let me know if everything works if those parameters are removed, I will make the necessary changes 😁 PS: I am actually new to open-source space, so I don't know how can I change the branch of this push request. I will do so after learning about it 😅 |
I have now confirmed that installing as a Flatpak with the |
Wow! Thank you so much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now - but just remembered that you should update the appdata release information when changes significantly impact the UX.
Okay! How can I do so? Sorry I am kind of new to opensource and stuff. Shall I make it 1.7.1? |
You need to edit Something like |
Got it, working on it |
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go - thanks!
I finally understand this. Will keep this in mind when I make a PR next time 👍 |
Fixes #155
Edited the desktop file to add a 'New Window' prompt when user right clicks.