Add option to mirror the webcam image #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordsm
changed the title
cassidyjames
previously requested changes
Oct 13, 2020
Co-authored-by: Cassidy James Blaede <cassidy@elementary.io>
|
@cassidyjames You mean like this?
I am having a hard time aligning the button, but at least this looks like an improvement over the initial version. What do you think? |
|
@igordsm I agree with Cassidy, You could use a ModeButton
|
|
Well, that's embarrassing. It was ModeButton and not ModelButton. Sorry about that. I'll try and fix it. |
|
@igordsm no, I did mean ModelButton, just with a switch—like we use in the Terminal settings popover. 😄
|
igordsm
changed the title
|
@cassidyjames 😆 You mean like this?
If you do, then this is ready for review. |
|
@igordsm yep, that's much closer. 😁 |
|
@cassidyjames I added
|
danirabbit
requested changes
Nov 12, 2020
Co-authored-by: Daniel Foré <daniel@elementary.io>
Co-authored-by: Cassidy James Blaede <cassidy@elementary.io>
danirabbit
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #38 : add option to mirror image.
Following the discussions on #67 , IMHO lacking this kind of feature may take users away from using camera. Specially when recording videos, being able to do simple adjustments directly from the app would make it infinitely more useful for me. I initially implemented it using a simple button, mas changed it to an app menu so that #51 could be implemented as well (I have a prototype, in fact).
What do you think? If you think its better to fix it one at a time I could change this one to use a "object-flip-horizontal" button, like below.