Brightness test

[alainm23]

This is just a test to change the brightness, it is not yet a solution, but we can see if the UI is OK or needs changes.

In case you noticed, yes, yes, I escape from the camera 👎

[danirabbit]

I'd like to hear from someone else in @elementary/ux but I personally am not sure it's within the scope of the Camera to digitally alter the image. I think this is potentially a slippery slope that will leads to features like filters being implemented here instead of in Photos where they make more sense (imo)

[cassidyjames]

@danrabbit depending on how this is implemented, it's not just a digital alteration. Lenses in webcams can actually have physical exposure controls that can't be well simulated digitally after the fact. It should definitely handle it automatically by default, but if you're in front of a window and the auto brightness is under-exposing your face, for example, being able to increase the brightness to over-expose the window and properly-expose your face is useful to be able to even take a photo.

[alainm23]

I understand the opinion of @danrabbit Make modular elementary, 'Camera' to take photos and 'Photos' to view and edit them, but there are some issues here:
A common user that comes from any other OS (WIndows, macOS, iOS, Android) is used to having your camera application have the basic functions (Photo, Video, Timer, Filters, Brightness and Contrast)
In my opinion, forcing the user to edit and put these filters from another application would not be a good user experience, a normal user wants to take a photo, put their filters and save them, nothing more.

[danirabbit]

I agree with @cassidyjames that if we're talking about changing the physical setting of the camera like aperture or ISO then we should be able to do that, but if we're talking about post then I think we should instead make it easy to open Photos and see the picture you've just taken

[danirabbit]

I'm going to close this PR since it now has conflicts and there's been no movement for a couiple weeks. Feel free to reopen if something changes :)