-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List Edit Mode for Markdown #894
Conversation
Great work! |
8d2caa3
to
bb1739f
Compare
Now that #890 has been accepted, this can be reviewed. I have already done a rebase and only the correct commits are present in this PR. Works as shown in the GIF above. Some thoughts about the current implementation:
Anyways, this is ready for a round of review for both code and functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected! Thanks for working on this. Sorry for taking a while to review 😅
Adds new items automatically when editing lists in Markdown. See below.
It has some limitations, though.
I am far from being an expert in TextBuffer and TextIter, but I am willing to work on top of this to get it in good shape.
This was created on top of #890 , so that PR should be considered first. When/if it is merged I can rebase this one so that only new commits are present.