-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Markdown plugin #890
Add Markdown plugin #890
Conversation
Ah, yeah Ctrl+I is the jump-to-line feature. Hrm. @danrabbit thoughts on that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments - review for functionality and regressions to follow.
I think all the shortcuts should work with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code works as expected and no regressions were found. Some coding issues are mentioned inline.
@jeremypw Thank you for the reviews! I have addressed all but one (left a comment in the discussion above) and re-request a review. I actually like using Edit: I am not sure how I removed |
Works nicely now - thank! But you will need to add an entry to the next release in the appdata file. I'll reinstate the review request to the ux team. |
By the way, the Flatpak CI is returning with a very non-specific error ( Edit: Nevermind. Works OK now. |
I have created a standalone repository https://github.com/igordsm/code-markdown-plugin that implements this PR and installs to the correct folders in Elementary 6. I started a discussion on third party plugins at #908 . I would be happy to hear your @jeremypw @cassidyjames thoughts about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work as expected except with undo. It looks like for some reason undo history sees either 2 or 3 actions. For example:
- Create some text
foo
- Highlight and Ctrl + Shift+ B for bold
- Notice that the text is now
**foo**
as expected - Press Ctrl + Z for undo
- Notice that the text is now
**foo
instead offoo
with links you'll notice that each bracket and the set of parentheses are treated individually
@igordsm If I remember correctly, the solution to this is to call |
@davidmhewitt Thank you. Just done that and it works as expected. @danrabbit undo/redo now work as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected! Nice job
This fixes #850 . Add a Markdown plugin with the following shortcuts:
See a demo below. All three works with and without a selection (and place the cursor where it makes sense).