Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement scrolling to switch windows #222

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Implement scrolling to switch windows #222

merged 6 commits into from
Apr 2, 2024

Conversation

leolost2605
Copy link
Member

Scrolling on top of a launcher icon will cycle through the windows.

Better with elementary/gala#1884

@leolost2605 leolost2605 requested a review from a team April 2, 2024 14:29
@danirabbit
Copy link
Member

@leolost2605 small conflict here. Should this be id or uid? 😅

@leolost2605
Copy link
Member Author

Probably uid since it's uid in AppWindow but I actually just want to quickly hold off on this and do a small performance adjustment :)

@leolost2605 leolost2605 marked this pull request as draft April 2, 2024 18:14
@leolost2605 leolost2605 marked this pull request as ready for review April 2, 2024 18:29
@leolost2605
Copy link
Member Author

@danirabbit should be ready again :)

danirabbit
danirabbit approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, appreciate good code comments!

@danirabbit danirabbit merged commit c87bbfa into main Apr 2, 2024
4 checks passed
@danirabbit danirabbit deleted the leolost/scroll branch April 2, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leolost2605 @danirabbit