Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show git status correctly after reload #2150

Merged
merged 9 commits into from
Apr 5, 2023
Merged

Show git status correctly after reload #2150

merged 9 commits into from
Apr 5, 2023

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Mar 5, 2023

Fixes #1161 - refresh status list when folder reloaded
Fixes #2168 - do not ignore folders incorrectly (do not add ignored files to the status map)

The latter issue was caused by ignored files' status being bubbled up to their non-ignored parent folder. Excluding them from the status map fixes this.

Install the PR in order to test.

@jeremypw jeremypw marked this pull request as ready for review April 5, 2023 09:31
@jeremypw jeremypw changed the title Refresh repo status list when folder reloaded Show git status correctly after reload Apr 5, 2023
@jeremypw jeremypw mentioned this pull request Apr 5, 2023
5 tasks
@danirabbit
Copy link
Member

I can't confirm that this fixes #1161

Steps to reproduce:

  1. Open files with this branch to a folder with a git tracked file you wish to modify
  2. Modify the file
  3. Notice that the git badge does not appear
  4. Refresh and still no change
  5. Close and reopen files and see the git badge

@jeremypw
Copy link
Collaborator Author

jeremypw commented Apr 5, 2023

@danirabbit Hmm, strange. As it is a plugin, you need to install the PR in order for it to work - just checking 😄

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yup lol. Silly me. Thanks! That works :)

@danirabbit danirabbit merged commit 1a3e7f0 into master Apr 5, 2023
@danirabbit danirabbit deleted the refresh-git branch April 5, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git status: Some folders ignored incorrectly Force update of git status when folder is refreshed
2 participants