Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gtk4Prep] Cleanup DnD #2418

Merged
merged 10 commits into from
Mar 7, 2024
Merged

[Gtk4Prep] Cleanup DnD #2418

merged 10 commits into from
Mar 7, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Mar 6, 2024

  • Move DnD utils into one file
  • Avoid unnecessary use of Gdk.DragContext (which does not exist in Gtk4)

Incorporates #2417 to facilitate testing

@jeremypw jeremypw requested a review from a team March 7, 2024 16:04
@danirabbit
Copy link
Member

I have a few errors here:

../src/View/Widgets/BreadcrumbsEntry.vala:81.33-81.45: error: Argument 1: Cannot convert from `void Files.View.Chrome.BreadcrumbsEntry.on_drag_leave (uint)' to `delegate void Gtk.Widget.drag_leave (Gtk.Widget, Gdk.DragContext, uint)'
   81 |             drag_leave.connect (on_drag_leave);
      |                                 ^~~~~~~~~~~~~  
../src/View/Widgets/BreadcrumbsEntry.vala:314.32-314.38: error: Argument 1: Cannot convert from `unowned Gdk.DragContext' to `uint'
  314 |                 on_drag_leave (context, timestamp);
      |                                ^~~~~~~             
../src/View/Widgets/BreadcrumbsEntry.vala:314.17-314.50: error: 1 extra arguments for `void Files.View.Chrome.BreadcrumbsEntry.on_drag_leave (uint)'
  314 |                 on_drag_leave (context, timestamp);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
../src/View/AbstractDirectoryView.vala:725.40-725.52: error: Argument 1: Cannot convert from `void Files.AbstractDirectoryView.on_drag_leave (uint)' to `delegate void Gtk.Widget.drag_leave (Gtk.Widget, Gdk.DragContext, uint)'
  725 |             widget.drag_leave.connect (on_drag_leave);

@jeremypw
Copy link
Collaborator Author

jeremypw commented Mar 7, 2024

@danirabbit Ooops! Don't know how I missed that.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the behavior is the same as in main (which I found some nice bugs 😅) :shipit:

@danirabbit danirabbit merged commit d714ab1 into main Mar 7, 2024
1 of 4 checks passed
@danirabbit danirabbit deleted the jeremypw/gtk4prep-move-dnd branch March 7, 2024 18:14
@jeremypw
Copy link
Collaborator Author

jeremypw commented Mar 7, 2024

@danirabbit Thanks for the review - I'll work on the bugs. Presumably caused by switching to EventControllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants