Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertiesWindow: redesign permisssions #2463

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

danirabbit
Copy link
Member

Attemping to address elementary/stylesheet#345

Uses icons that have \ states and non-linked buttons to try to make it clearer which permissions are selected

AFTER

Screenshot from 2024-08-28 13 03 12

BEFORE

Screenshot from 2024-08-28 13 05 23

@danirabbit danirabbit requested a review from a team August 28, 2024 20:08
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Just a query about the ordering.

src/Dialogs/PropertiesWindow.vala Outdated Show resolved Hide resolved
@jeremypw jeremypw merged commit c625efc into main Aug 30, 2024
4 checks passed
@jeremypw jeremypw deleted the danirabbit/propertieswindow-permissionredesign branch August 30, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants