Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set accent color based on wallpaper #1104

Merged
merged 15 commits into from Apr 29, 2021

Conversation

meisenzahl
Copy link
Member

@meisenzahl meisenzahl commented Apr 8, 2021

@meisenzahl
Copy link
Member Author

Demo in interaction with elementary/switchboard-plug-pantheon-shell#263:

Peek.2021-04-09.23-55.mp4

@meisenzahl
Copy link
Member Author

I had to revert a2da4bb unfortunately, otherwise it doesn't reliably detect when the accent color preference changes.

README.md Outdated Show resolved Hide resolved
src/AccentColor/AccentColorManager.vala Show resolved Hide resolved
src/AccentColor/AccentColorManager.vala Show resolved Hide resolved
src/AccentColor/ColorExtractor.vala Show resolved Hide resolved
@meisenzahl
Copy link
Member Author

@JoseExposito thank you for your detailed review and your suggestions! I would be happy if you would find time for a review again 😀️

@JoseExposito
Copy link
Member

JoseExposito commented Apr 11, 2021

The code looks good. I didn't go through the colour extractor algorithm with a lot of detail, but it works like a charm.
Once the other PRs are reviewed, we can do test it with everything in place and merge it.

Awesome feature by the way, love it!

@martinstork
Copy link

Doesn't this feature need some kind of toggle? As someone who changes wallpapers frequently, but keeps the accent color blue, this wouldn't be a welcome change if it can't be turned off.

@JoseExposito
Copy link
Member

@martinstork yes, there is a switch for it here elementary/switchboard-plug-pantheon-shell#263

@martinstork
Copy link

@martinstork yes, there is a switch for it here elementary/switchboard-plug-pantheon-shell#263

Oh my bad. Thanks. I tried to move my comment there, but you were too fast 😅

@cassidyjames cassidyjames merged commit 5cf9308 into master Apr 29, 2021
@cassidyjames cassidyjames deleted the set-accent-color-based-on-wallpaper branch April 29, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants