Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set accent color based on wallpaper #126

Merged
merged 10 commits into from Apr 29, 2021
Merged

Set accent color based on wallpaper #126

merged 10 commits into from Apr 29, 2021

Conversation

meisenzahl
Copy link
Member

Related to elementary/gala#1104

Works in conjunction with elementary/granite#483

Pretty much the same code as in elementary/switchboard-plug-pantheon-shell#263

Bildschirmfoto von 2021-04-11 22 03 55

@meisenzahl meisenzahl mentioned this pull request Apr 13, 2021
Merged
JoseExposito
JoseExposito approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@JoseExposito JoseExposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is very similar to the switchboard plugin, looking great ❤️

With the current UI I don't find obvious what happens when the "colourless" circle is selected, but I leave that for the @elementary/ux team.

cassidyjames
cassidyjames suggested changes Apr 24, 2021
View reviewed changes
Copy link
Contributor

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks close—just a few comments. I think we want to figure out styling for that auto radio before we merge, though, likely with a conic gradient set as the radio's background.

src/Views/StyleView.vala Outdated Show resolved Hide resolved
src/Views/StyleView.vala Outdated Show resolved Hide resolved
src/Views/StyleView.vala Outdated Show resolved Hide resolved
@cassidyjames cassidyjames merged commit 83dbbf8 into master Apr 29, 2021
@cassidyjames cassidyjames deleted the set-accent-color-based-on-wallpaper branch April 29, 2021 22:39
@meisenzahl meisenzahl mentioned this pull request Apr 30, 2021
Merged
@meisenzahl meisenzahl mentioned this pull request May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassidyjames cassidyjames cassidyjames approved these changes

@JoseExposito JoseExposito JoseExposito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meisenzahl @cassidyjames @JoseExposito