Handle GTK4 notification bubbles #1427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Hm @tintou do you know if there’s a better way to identify these windows if we can’t set type? Or if we can still set type somehow? |
|
We need a custom protocol on Wayland, for X11 it's not possible anymore in GTK4 (without custom code poking the X.Window directly which we don't want to invest on) |
|
Basically the way to go is to test if https://gitlab.gnome.org/GNOME/vala/-/merge_requests/246 is working and use it |
|
Closing as non-practical way of solving the problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with : elementary/notifications#157
It handles GTK4 notification bubbles by anticipating the unique window title set on the notification bubbles "io.elementary.notifications". The window title is hidden, it just acts more of an identifier. This is done because we can't set the type hint of Windows in GTK4, resulting in the window manager treating notification bubbles as normal windows.