Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColorManager for theme accent color #1857

Closed
wants to merge 5 commits into from

Conversation

leolost2605
Copy link
Member

  • Gets the theme accent color from settings portal
  • Add a ColorManager because we are going to need it for more things like background color light and dark, tooltip color etc. since we currently use gtk.stylecontext for these colors and this is problematic (see Remove the usage of GTK inside the compositor #1839)

Fixes #1674

First step towards #1839

@leolost2605 leolost2605 requested a review from a team February 18, 2024 19:09
@tintou
Copy link
Member

tintou commented Mar 1, 2024

While I agree with the implementation, I don't think that we should use the portal as the portal will be available after Gala. For this I think that we should use the elementary AccountService extension

@leolost2605
Copy link
Member Author

I updated it to use the AccountsService :)

@leolost2605 leolost2605 requested a review from tintou March 3, 2024 19:23
@leolost2605 leolost2605 marked this pull request as draft March 22, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Get accent from settings portal
2 participants