Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a StyleManager #1880

Merged
merged 13 commits into from
Mar 26, 2024
Merged

Introduce a StyleManager #1880

merged 13 commits into from
Mar 26, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Mar 22, 2024

This is pretty much #1857 and therefore closes #1857

Only a bit refactored and it will now also be used to get the color scheme. This is because currently granite is used to get the color scheme which in turn uses the portal. This caused start time on wayland to be > 20 seconds since we are waiting for the portal. This PR reduces start time to the same as on X so about 1 - 2 seconds.

Fixes #1674

Continues towards #1839 (AFAIK only shadow effect is now still using GTK)

@leolost2605 leolost2605 requested review from tintou and a team March 22, 2024 14:38
@leolost2605
Copy link
Member Author

My laptop just ran out of battery lol 🥲
I still need to do a push then this should be ready

@leolost2605 leolost2605 marked this pull request as draft March 22, 2024 14:54
@leolost2605 leolost2605 marked this pull request as ready for review March 22, 2024 17:01
@leolost2605
Copy link
Member Author

We could now also drop Granite as a dependency for the gala lib and main gala executable however that would be an API break since Drawing.Color implements Granite SettingsSerializable. Not sure how we handle gala API? Is it supposed to be stable?

@danirabbit
Copy link
Member

I think the only thing using Gala API is other Pantheon components so should be okay to break imo 🤷🏻‍♀️

@leolost2605
Copy link
Member Author

leolost2605 commented Mar 22, 2024

Ok I dropped the granite dependency in libgala and gala but I left the methods that are implementing settingsserializable in Drawing.Color so that plugins that in theory exist and need it are only a line change and recompile away from getting it working again. Dropping these can probably be done in follow up PRs IMHO.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected and we have tintou's ack on the other PR with his suggestion to use accountsservice so I'm happy with that 🚀

@danirabbit danirabbit enabled auto-merge (squash) March 26, 2024 17:02
@danirabbit danirabbit merged commit 4c6f503 into master Mar 26, 2024
4 checks passed
@danirabbit danirabbit deleted the leolost/style-manager branch March 26, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Get accent from settings portal
2 participants