Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render shadows using Gtk #250

Merged
merged 9 commits into from
Jul 29, 2018
Merged

Render shadows using Gtk #250

merged 9 commits into from
Jul 29, 2018

Conversation

tintou
Copy link
Member

@tintou tintou commented May 15, 2018

It's not ready to merge until @elementary/ux fixes the CSS ;)

@danirabbit
Copy link
Member

Can we get an additional style class for the workspace itself so we can style that differently than the windows. Maybe .decoration.workspace?

@danirabbit
Copy link
Member

Hm something I noticed is that it seems like only maximized windows actually need additional box shadow. Other windows already have it, including SSD windows.

screenshot from 2018-05-15 09 37 28 2x

danirabbit
danirabbit previously approved these changes May 15, 2018
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good!

@tintou tintou requested a review from ricotz May 29, 2018 15:04
@peteruithoven
Copy link
Collaborator

Any change this will influence #104 ? Because libwnck might get a different window geometry?

@cassidyjames
Copy link
Contributor

@peteruithoven no, this shouldn't affect that since it's only in the window overview.

Copy link
Contributor

@donadigo donadigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing in the code.

src/Widgets/WindowClone.vala Show resolved Hide resolved
Copy link
Contributor

@donadigo donadigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cassidyjames cassidyjames merged commit 15f722a into master Jul 29, 2018
@cassidyjames cassidyjames deleted the tintou/shadow-gtk branch July 29, 2018 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants