Adapt to mutter 3.33 #566

tintou · 2019-06-25T16:50:17Z

It is building and basically working for Mutter 3.33.3 so let's iterate after on this

donadigo

It looks good and compiles on 3.28. I wonder if in the future we should split up the functions by versions to different files since it's getting quite crowded there.

worldofpeace · 2019-07-04T02:56:16Z

Tested in a VM with NixOS (master has GNOME 3.32).

Noticed that Multitasking View always had four workspaces

I'd say that's a regression from the current state.

Also trying to switch a workspace with a shortcut would only result in the limiter animation.

Dirli · 2019-07-05T17:50:12Z

Mutter API removed the override_preference_schema func. and now Gala is not setting its own settings. At least I ran into this when I adapted it to 3.30. for myself I decided to directly overwrite the necessary schemes, but it worked:

WindowManager.vala ( public WindowManagerGala () ):

var mutter_schema = new GLib.Settings ("org.gnome.mutter");
mutter_schema.set_boolean ("dynamic-workspaces", BehaviorSettings.get_default ().dynamic_workspaces);
mutter_schema.set_boolean ("edge-tiling", BehaviorSettings.get_default ().edge_tiling);
mutter_schema.set_boolean ("attach-modal-dialogs", AppearanceSettings.get_default ().attach_modal_dialogs);

var general_schema = new GLib.Settings ("org.gnome.desktop.wm.preferences");
general_schema.set_string ("button-layout", AppearanceSettings.get_default ().button_layout);

var interface_schema = new GLib.Settings ("org.gnome.desktop.interface");
interface_schema.set_boolean ("enable-animations", AnimationSettings.get_default ().enable_animations);

alucryd · 2019-07-11T20:14:18Z

It's almost building fine on archlinux, but I'm getting a bunch of these:

FAILED: src/25a6634@@gala@exe/meson-generated_Background_BackgroundContainer.c.o 
cc -Isrc/25a6634@@gala@exe -Isrc -I../gala/src -I. -I../gala/ -Ilib -I../gala/lib -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/libffi-3.2.1/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/gee-0.8 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libdrm -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/plank -I/usr/include/libbamf3 -I/usr/lib/libbamf3/include -I/usr/include/mutter-4 -I/usr/include/gsettings-desktop-schemas -I/usr/include/mutter-4/clutter -I/usr/include/json-glib-1.0 -I/usr/include/mutter-4/cogl -I/usr/include/granite -I/usr/include/gnome-desktop-3.0 -flto -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -w -Wno-discarded-qualifiers -Wno-incompatible-pointer-types -Wno-unused -Wl,--enable-new-dtags '-DGETTEXT_PACKAGE="gala"' -DGNOME_DESKTOP_USE_UNSTABLE_API '-DDATADIR="/usr/share"' '-DPKGDATADIR="/usr/share/gala"' '-DPKGLIBDIR="/usr/lib/gala"' '-DPLUGINDIR="/usr/lib/gala/plugins"' '-DSCHEMA="org.pantheon.desktop.gala"' '-DRESOURCEPATH="/org/pantheon/desktop/gala"' -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_44 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_44 -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_10 -DGDK_VERSION_MAX_ALLOWED=GDK_VERSION_3_10 -DCLUTTER_ENABLE_COMPOSITOR_API -DCLUTTER_ENABLE_EXPERIMENTAL_API -DCOGL_ENABLE_EXPERIMENTAL_API -DCOGL_ENABLE_EXPERIMENTAL_2_0_API -march=x86-64 -mtune=generic -O2 -fno-plt -D_FORTIFY_SOURCE=2 -pthread -MD -MQ 'src/25a6634@@gala@exe/meson-generated_Background_BackgroundContainer.c.o' -MF 'src/25a6634@@gala@exe/meson-generated_Background_BackgroundContainer.c.o.d' -o 'src/25a6634@@gala@exe/meson-generated_Background_BackgroundContainer.c.o' -c 'src/25a6634@@gala@exe/Background/BackgroundContainer.c'
src/25a6634@@gala@exe/Background/BackgroundContainer.c:62:22: error: field ‘parent_instance’ has incomplete type
   62 |  MetaBackgroundGroup parent_instance;
      |                      ^~~~~~~~~~~~~~~

Do you have any idea how this could happen? Note that we already have GCC 9, so it might be pickier than previous versions.

worldofpeace · 2019-07-12T01:59:45Z

@alucryd Mutter needs this patch @tintou submitted for it to work

https://gitlab.gnome.org/GNOME/mutter/commit/bd7704f9e17e9554ad663386ef4fce1e16a56f08

alucryd · 2019-07-12T06:18:09Z

@worldofpeace Thanks for the pointer, I'll try to get this commit backported into our mutter package.

worldofpeace · 2019-07-12T07:04:52Z

Mutter API removed the override_preference_schema func. and now Gala is not setting its own settings. At least I ran into this when I adapted it to 3.30. for myself I decided to directly overwrite the necessary schemes, but it worked:

Indeed this is true in 3.30

https://gitlab.gnome.org/GNOME/mutter/commit/3d75b48d50fe7773b3ad2231732f897c0a8a7874

They've replaced it with per desktop GSettings overrides

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/46/diffs

Not sure if that API is present in elementary (ref elementary/default-settings#114)
but if we can confirm that I can submit a pr.

decathorpe · 2019-09-10T15:09:45Z

@tintou I just noticed mutter bumped the libraries again (to -5 versions) before the final 3.34.0 release ...

decathorpe · 2019-10-26T08:36:38Z

I'll try to build from this branch for fedora.

FYI, mutter bumped again 😦 to libmutter-6 with 3.35.1, so I'll not be able to use this on rawhide yet, but only on fedora 31 and maybe 30 (if this works).

decathorpe · 2019-10-26T08:42:05Z

Aaaaaand this doesn't compile on fedora 31 / mutter 3.34.1 with these errors:

../src/WindowManager.vala:1759.4-1759.17: error: The type name `Screen' could not be found
			unowned Screen screen = get_screen ();
			^^^^^^^^^^^^^^
../src/WindowManager.vala:1780.4-1780.17: error: The type name `Screen' could not be found
			unowned Screen screen = get_screen ();
			^^^^^^^^^^^^^^
Compilation failed: 2 error(s), 0 warning(s)

Dirli · 2019-10-26T09:03:55Z

I'll try to build from this branch for fedora.

FYI, mutter bumped again to libmutter-6 with 3.35.1, so I'll not be able to use this on rawhide yet, but only on fedora 31 and maybe 30 (if this works).

do not dream, at the moment above mutter30 gala does not want to work, I tried to build this branch on 32 in gentoo, everything was compiled but falls with an error at startup

decathorpe · 2019-10-29T12:42:25Z

@tintou thanks, it now correctly finds libmutter-6 on rawhide, but now it fails with the same compilation error as on fedora 31:

../src/WindowManager.vala:1759.4-1759.17: error: The type name `Screen' could not be found
			unowned Screen screen = get_screen ();
			^^^^^^^^^^^^^^
../src/WindowManager.vala:1780.4-1780.17: error: The type name `Screen' could not be found
			unowned Screen screen = get_screen ();
			^^^^^^^^^^^^^^
Compilation failed: 2 error(s), 0 warning(s)

decathorpe · 2019-10-29T15:12:16Z

@tintou great, I can confirm that with your latest commit this branch compiles on both fedora 31 and rawhide. I've submitted a build for testing to my elementary-staging COPR repo.

worldofpeace · 2019-10-29T15:37:48Z

@tintou Good here for NixOS as well, with mutter 3.34.1.
Some warnings though:

https://gist.github.com/worldofpeace/a553df6d7e89c777619d290168ad5d5f

but it does build 👍

decathorpe · 2019-10-29T16:36:29Z

@tintou looks like it works. maybe. the crashes I'm seeing are probably because the wingpanel gala plugin is still getting linked with libmutter 3.28, and loading both libs into a process at the same time is probably what messes things up.

decathorpe · 2019-10-30T12:56:29Z

@tintou I have adapted the changes from this PR for wingpanel. I still get the fail-whale screen, but now at least wingpanel start correctly 🙁

https://github.com/decathorpe/wingpanel/tree/wip/mutter-3.3x

decathorpe · 2019-10-30T12:59:57Z

This is the crash backtrace from gala:

Process 1447 (gala) of user 1000 dumped core.

Stack trace of thread 1447:
#0  0x00007f395d686659 g_type_check_instance_is_fundamentally_a (libgobject-2.0.so.0)
#1  0x00007f395d6666a7 g_object_ref (libgobject-2.0.so.0)
#2  0x000055a5a5bbc3e4 gala_workspace_manager_workspace_added (gala)
#3  0x000055a5a5bbd230 gala_workspace_manager_constructor (gala)
#4  0x00007f395d66721c g_object_new_internal (libgobject-2.0.so.0)
#5  0x00007f395d669338 g_object_new_valist (libgobject-2.0.so.0)
#6  0x00007f395d66968d g_object_new (libgobject-2.0.so.0)
#7  0x000055a5a5bbcf18 gala_workspace_manager_init (gala)
#8  0x000055a5a5bb7a7d _gala_window_manager_gala_show_stage_gsource_func (gala)
#9  0x00007f395c90d37f run_all_repaint_laters (libmutter-5.so.0)
#10 0x00007f395c7658ca _clutter_run_repaint_functions (libmutter-clutter-5.so.0)
#11 0x00007f395c7672dd clutter_clock_dispatch (libmutter-clutter-5.so.0)
#12 0x00007f395d5774a0 g_main_context_dispatch (libglib-2.0.so.0)
#13 0x00007f395d577830 g_main_context_iterate.isra.0 (libglib-2.0.so.0)
#14 0x00007f395d577b23 g_main_loop_run (libglib-2.0.so.0)
#15 0x00007f395c8fe7e0 meta_run (libmutter-5.so.0)
#16 0x000055a5a5ba2886 gala_main (gala)
#17 0x00007f395c2411a3 __libc_start_main (libc.so.6)
#18 0x000055a5a5b9a17e _start (gala)

worldofpeace · 2019-10-30T13:33:28Z

Cool @decathorpe, I'm trying that patch with debugging and a full rebuild currently.

It seems someone else dropped a patch for wingpanel with 3.30 mutter btw.

https://gist.github.com/Tireg/f4c6e28258601dedb73aca517d322806

I actually cannot reproduce the issue you have there on NixOS. Perhaps this is because everything forces a full-rebuild over here for purity, so I would try rebuilding the indicators etc.

using this is nixos
worldofpeace/nixpkgs@f752dbf

Edit:

I was able to get a crash on an existing system, however there's no problems in a clean vm where I was testing in. Here's a full backtrace with symbols

https://gist.github.com/worldofpeace/8e2d3ff4a442a09454a6b91e69af290b

worldofpeace · 2019-10-30T16:59:30Z

@tintou I have adapted the changes from this PR for wingpanel. I still get the fail-whale screen, but now at least wingpanel start correctly slightly_frowning_face

https://github.com/decathorpe/wingpanel/tree/wip/mutter-3.3x

I've now done the same for elementary-greeter elementary/greeter#377.
It would be amazing if you PR'd that patch, it appears to be the most straightforward of all the ports.

donadigo

The tests pass and so I think it's not worth to hold it off even longer. Let's go.

Dirli · 2019-11-02T16:40:00Z

well, how can you merge it if it doesn't work? i'm testing Debian (testing), ArchLinux, Gentoo, and all fail.
you were shown the error above.

worldofpeace · 2019-11-02T21:52:40Z

@Dirli It doesn't work without wingpanel also being ported to latest mutter.

Dirli · 2019-11-03T09:49:44Z

This is the crash backtrace from gala:

Process 1447 (gala) of user 1000 dumped core.

Stack trace of thread 1447:
#0  0x00007f395d686659 g_type_check_instance_is_fundamentally_a (libgobject-2.0.so.0)
#1  0x00007f395d6666a7 g_object_ref (libgobject-2.0.so.0)
#2  0x000055a5a5bbc3e4 gala_workspace_manager_workspace_added (gala)
#3  0x000055a5a5bbd230 gala_workspace_manager_constructor (gala)
#4  0x00007f395d66721c g_object_new_internal (libgobject-2.0.so.0)
#5  0x00007f395d669338 g_object_new_valist (libgobject-2.0.so.0)
#6  0x00007f395d66968d g_object_new (libgobject-2.0.so.0)
#7  0x000055a5a5bbcf18 gala_workspace_manager_init (gala)
#8  0x000055a5a5bb7a7d _gala_window_manager_gala_show_stage_gsource_func (gala)
#9  0x00007f395c90d37f run_all_repaint_laters (libmutter-5.so.0)
#10 0x00007f395c7658ca _clutter_run_repaint_functions (libmutter-clutter-5.so.0)
#11 0x00007f395c7672dd clutter_clock_dispatch (libmutter-clutter-5.so.0)
#12 0x00007f395d5774a0 g_main_context_dispatch (libglib-2.0.so.0)
#13 0x00007f395d577830 g_main_context_iterate.isra.0 (libglib-2.0.so.0)
#14 0x00007f395d577b23 g_main_loop_run (libglib-2.0.so.0)
#15 0x00007f395c8fe7e0 meta_run (libmutter-5.so.0)
#16 0x000055a5a5ba2886 gala_main (gala)
#17 0x00007f395c2411a3 __libc_start_main (libc.so.6)
#18 0x000055a5a5b9a17e _start (gala)

@worldofpeace here you are shown an error, and yes, I ran the wingpanel supports the latest mutter. if you look at my screenshot (second), you will see that just the wingpanel started.

tintou · 2019-11-03T11:01:01Z

Yeah it's not because it's building that it's completely working, it's a starting point though, we don't officially support any version different that the one we ship with elementary anyway so there is no guarantee.

worldofpeace · 2019-11-03T14:44:09Z

Yeah it's not because it's building that it's completely working, it's a starting point though, we don't officially support any version different that the one we ship with elementary anyway so there is no guarantee.

Umm, don't know how I feel about this then. It seems from the build system that you allow it to be built with many different versions, and if you don't actually plan to officially support this at all then I believe you shouldn't try too. So I'm under the assumption that you must if this is the case?
I don't think it would be an unreasonable request to support the last two latest mutter releases 3.32 and 3.34 and obviously it will work with 3.28, but if there is no plan to even proclaim that, what hope is this for downstreams? Of course your platform is going to be top priority, I completely understand this, but it goes without saying how it's unfair to add support in the code but proclaim support is unwarranted. In NixOS Pantheon is part of our release, so I'd really like to know if I need to keep compat packages for mutter and g-s-d indefinitely or if porting to different versions will be worth my time?

worldofpeace · 2019-11-03T14:46:32Z

Granted resources will dictate these sort of things majorly. Hopefully this wouldn't be misconstrued as contributions being unwelcome also.

Dirli · 2019-11-03T15:34:35Z

@tintou Maybe it makes sense to fork mutter, so as not to chase gnome, and carefully embed new features, while maintaining support. Of course this will require more costs, but perhaps these costs will be less th race for mutter api?

tintou · 2019-11-03T16:41:10Z

No, we have no plan to fork mutter because it's great as it is an accepts our patches, we just have to rebase every 2 weeks on our end, we're more than happy to have patch that fixes it for latest mutter but we can't even pretend that it might work on any version other than the one shipped by elementary. We don't have that manpower but again, patches are welcome.

Tireg · 2019-11-04T19:28:41Z

Ok so I have been able to work some issues mentionned by @Dirli, @worldofpeace and @decathorpe.

First, thanks @tintou and everyone for your hard work upon mutter 3.3x APIs, its really easier to build everything. Their are still some issues but this is still a great improvement.

Some details about my environment:

OS: Gentoo
Gala version: upstream
Mutter version: 3.32.2

Required mutter patches:

Mutter needs to be patched (until the patch is merged upstream: https://gitlab.gnome.org/GNOME/mutter/commit/bd7704f9e17e9554ad663386ef4fce1e16a56f08)
Thanks @worldofpeace for the hint !

Required Gala patches

When mutter 3.32 is used, I couldn't build gala without this patch: https://gist.github.com/Tireg/40a88ef867e978644ef3024d3d28ec55
Since mutter 3.30 (I think, can't remember whether it's 3.30 or 3.32), we need gsettings overrides that matches old behaviour: https://gist.github.com/Tireg/7af22e747425b5a4f52b055a7b878a73
This is what @Dirli mentionned at Adapt to mutter 3.33 #566 (comment)
WARNING: This is not a fix, this is a workaround which has other issues.
In order to be able to start gala, we may temporarily remove calls to problematic functions with this patch: https://gist.github.com/Tireg/27e7ab0225efb8ceec47566d2bfc2b07
This will entirely remove support for automatic workspace cleanup. As gala does not provide any way to remove workspaces from the GUI, empty workspaces will never be deleted. Workspaces will just accumulate with no way to clean them unless restart the session.
This is a workaround against the bug reported by Adapt to mutter 3.33 #566 (comment) (stacktrace at gala_workspace_manager_workspace_removed)
An alternative patch is: https://gist.github.com/Tireg/2af03fa2d602d6112868eb722f2d27f1
This will keep auto-cleaning of the workspaces but causes bugs under specific circumstances (workspaces add = segfault, workspace switch from empty workspace = abort)

Optionnal patches

In order to backport support for reorder workspace, we need to patch mutter with the following patch (tested with mutter 3.32, unnecessary since mutter 3.34): https://gist.github.com/Tireg/49b5efc9db4a79232e093452a0d29759
This also requires patching the current gala code: https://gist.github.com/Tireg/f5513ad7693e17dfddcf2f920dc8785f

Other bugs

I didn't encountered the bug reported by @decathorpe and @Dirli (#566 (comment)).
Is this with mutter 3.34 ?

Remove workspace bug

@tintou The bug seems to be within Gala.WorkspaceManager.remove_workspace function.
I'm not really a vala developper and don't understand the how and the why, but almost any calls to remove_workspace ends up with a gala crash.
I tried to run gdb against gala (with every calls to remove_workspace disabled except the one within Gala.WorkspaceManager.workspace_switched) but couldn't figure the source of the problem. I don't have any setup with debugging symbols nor source code of every component so the output were very limited.
It seems to be an index problem (raised upon mutter code but I don't know whether it's mutter or gala).

If you have any idea that may help debugging, I'd gladly use them to find the origin of this issue.

Edit

Ok after some investigation, it seems both #566 (comment) and #566 (comment) comes from the callback changes.

For Adapt to mutter 3.33 #566 (comment), the callback Gala.WorkspaceManager.workspace_removed () calls workspace.index () (https://github.com/elementary/gala/pull/566/files#diff-3c621372cc3a9bae11f71f0db0419664R138) to check if it is negative. However, the mutter code specifies that calling index () function when it returns a negative number (workspace does not exists within workspace manager) is a bug.
It raises a bug (meta-bug ()): https://gitlab.gnome.org/GNOME/mutter/blob/gnome-3-32/src/core/workspace.c#L677 and then aborts the program: https://github.com/GNOME/mutter/blob/master/src/core/util.c#L423
There seems to be no such equivalent to the pre 3.30 algorithm (check if the workspace still exists within the meta list of existing workspaces) and some new algorithm is required to delete the proper workspace (register index with the associated workspace within the Gala.WorkspaceManager.remove_workspace () function to be able to find it with the callback index argument ?)
For Adapt to mutter 3.33 #566 (comment) however, it seems to be a deeper bug as this is a core dump. The function Gala.WorkspaceManager.workspace_added () (https://github.com/elementary/gala/pull/566/files#diff-3c621372cc3a9bae11f71f0db0419664R125) translates:
```
var workspace = manager.get_workspace_by_index (index);
```
to
```
MetaWorkspace* workspace = NULL;
MetaWorkspace* _tmp0_;
MetaWorkspace* _tmp1_;
g_return_if_fail (self != NULL);
g_return_if_fail (manager != NULL);
_tmp0_ = meta_workspace_manager_get_workspace_by_index (manager, index);
_tmp1_ = _g_object_ref0 (_tmp0_);
workspace = _tmp1_;
```
with
```
static gpointer
_g_object_ref0 (gpointer self)
{
        return self ? g_object_ref (self) : NULL;
}
```
This crashes right within the call to _g_object_ref0, which calls g_object_ref and so this is entirely libgobject code.
The stack trace describes using G_IS_OBJECT from https://github.com/GNOME/glib/blob/mainline/gobject/gobject.c#L3344,
which expands to G_TYPE_CHECK_INSTANCE_FUNDAMENTAL_TYPE from https://github.com/GNOME/glib/blob/mainline/gobject/gobject.h#L66,
which expands to _G_TYPE_CIFT from https://github.com/GNOME/glib/blob/mainline/gobject/gtype.h#L510
which finally expands to g_type_check_instance_is_fundamentally_a from https://github.com/GNOME/glib/blob/mainline/gobject/gtype.h#L2310
which crashes (without saying line) within the function https://github.com/GNOME/glib/blob/mainline/gobject/gtype.c#L4022

Maybe some vala / libgobject version is required to make this work properly ? Maybe vapi is incorrect ? Any other calls to this function and related assignments seems to work properly.
Maybe a bug within libgobject ?

Anyway, we could use the help of any experimented vala developper.

Tireg · 2019-11-07T20:29:18Z

More bugs found across investigation (with this patch applied: https://gist.github.com/Tireg/2af03fa2d602d6112868eb722f2d27f1):

Adding workspace (by opening a window on the last workspace) seems to frequently crash gala. Here is one stacktrace on opening a windows on the last workspace when only 2 workspaces are opened:

nov. 07 20:45:39 gentoo systemd-coredump[2845832]: Process 2823595 (gala) of user 1001 dumped core.

Stack trace of thread 2823595:
#0  0x00007fe99eba2e75 g_type_check_instance_is_fundamentally_a (libgobject-2.0.so.0)
#1  0x00007fe99eb82e4e g_object_ref (libgobject-2.0.so.0)
#2  0x000000000025521b gala_workspace_manager_workspace_added (gala)
#3  0x00007fe99eb7df1d g_closure_invoke (libgobject-2.0.so.0)
#4  0x00007fe99eb91888 signal_emit_unlocked_R (libgobject-2.0.so.0)
#5  0x00007fe99eb9aaae g_signal_emit_valist (libgobject-2.0.so.0)
#6  0x00007fe99eb9b157 g_signal_emit (libgobject-2.0.so.0)
#7  0x00007fe99de7290f meta_workspace_manager_append_new_workspace (libmutter-4.so.0)
#8  0x000000000025492a gala_workspace_manager_window_added (gala)
#9  0x00007fe99eb7df1d g_closure_invoke (libgobject-2.0.so.0)
#10 0x00007fe99eb91888 signal_emit_unlocked_R (libgobject-2.0.so.0)
#11 0x00007fe99eb9aaae g_signal_emit_valist (libgobject-2.0.so.0)
#12 0x00007fe99eb9b157 g_signal_emit (libgobject-2.0.so.0)
#13 0x00007fe99de8899b meta_workspace_add_window (libmutter-4.so.0)
#14 0x00007fe99de7dbed set_workspace_state (libmutter-4.so.0)
#15 0x00007fe99de83f46 _meta_window_shared_new (libmutter-4.so.0)
#16 0x00007fe99de9eede meta_window_x11_new (libmutter-4.so.0)
#17 0x00007fe99de8f518 handle_other_xevent (libmutter-4.so.0)
#18 0x00007fe99de8fd6b xevent_filter (libmutter-4.so.0)
#19 0x00007fe99e21f567 n/a (libgdk-3.so.0)
#20 0x00007fe99e1e74ed gdk_display_get_event (libgdk-3.so.0)
#21 0x00007fe99e21fcf2 n/a (libgdk-3.so.0)
#22 0x00007fe99ea9858d g_main_context_dispatch (libglib-2.0.so.0)
#23 0x00007fe99ea98828 g_main_context_iterate.isra.26 (libglib-2.0.so.0)
#24 0x00007fe99ea98b32 g_main_loop_run (libglib-2.0.so.0)
#25 0x00007fe99de6e4fc meta_run (libmutter-4.so.0)
#26 0x000000000023beec gala_main (gala)
#27 0x00007fe99d7e1edb __libc_start_main (libc.so.6)
#28 0x000000000023402a _start (gala)

This is still related to https://github.com/elementary/gala/pull/566/files#diff-3c621372cc3a9bae11f71f0db0419664R125 and I don't know how to deal with this one.

This occur under some really specific circumstances:

Directly at first login, right after Gala proceeded to clean-up the initial workspace to delete everything except the main workspace, moving a windows to -- or creating a windows within -- the spare workspace (the one with a "+" sign) result in this bug.
Once a first crash occurred, create a window within the spare workspace result in the bug. This is not the case however when moving a window to the spare workspace (either through the contextual window menu -- right click on the title bar then move to right workspace -- or through the Multitasking-View)

Another bug while trying to switch from an empty workspace (which is not the last workspace) to another workspace, with and without the Multi-Tasking view (triggering the removal of the initial workspace):

Bug in window manager: Workspace does not exist to index!
==2815771== 
==2815771== Process terminating with default action of signal 6 (SIGABRT): dumping core
==2815771==    at 0x5CE7F5B: raise (in /lib64/libc-2.29.so)
==2815771==    by 0x5CD1534: abort (in /lib64/libc-2.29.so)
==2815771==    by 0x57A39F4: meta_bug (in /usr/lib64/libmutter-4.so.0.0.0)
==2815771==    by 0x57B000D: meta_workspace_index (in /usr/lib64/libmutter-4.so.0.0.0)
==2815771==    by 0x261C4E: gala_multitasking_view_update_positions (in /usr/bin/gala)
==2815771==    by 0x26232F: _gala_multitasking_view_remove_workspace_meta_workspace_manager_workspace_removed (in /usr/bin/gala)
==2815771==    by 0x4A8EF1C: g_closure_invoke (in /usr/lib64/libgobject-2.0.so.0.6000.7)
==2815771==    by 0x4AA2887: signal_emit_unlocked_R (in /usr/lib64/libgobject-2.0.so.0.6000.7)
==2815771==    by 0x4AABAAD: g_signal_emit_valist (in /usr/lib64/libgobject-2.0.so.0.6000.7)
==2815771==    by 0x4AAC156: g_signal_emit (in /usr/lib64/libgobject-2.0.so.0.6000.7)
==2815771==    by 0x579B5CE: meta_workspace_manager_remove_workspace (in /usr/lib64/libmutter-4.so.0.0.0)
==2815771==    by 0x254671: gala_workspace_manager_remove_workspace (in /usr/bin/gala)
[... REMOVED valgrind MEMORY LEAKS SUMMARY ...]
[1]    2815771 abort (core dumped)  valgrind gala --replace

This is yet another call to workspace index () function (https://github.com/elementary/gala/blob/master/src/Widgets/MultitaskingView.vala#L315), which triggers an error according to mutter.

It seems MultiTasking view still has workspace that may not be indexed within Meta.WorkspaceManager when the function is called (probably deleted from the manager).

Mutter starts by emitting the active-workspace-changed signal (https://gitlab.gnome.org/GNOME/mutter/blob/gnome-3-32/src/core/meta-workspace-manager.c#L317) which triggers an update_position according to https://github.com/elementary/gala/blob/master/src/Widgets/MultitaskingView.vala#L95 (I suppose so, can't really confirm but this is the observed behaviour) before triggering the workspace-removed signal. This cause the index () call on an already deleted workspace that can't be indexed.

Anyway, mutter 3.3x may have broken more things than expected within gala.

Tireg · 2019-11-08T12:30:37Z

Finally managed to create patch to fix it properly.

I still got some bugs with the patched version, so I opened a new issue in order to discuss each patch created and bugs that are still present.
Please, continue this discussion and report related bugs to this bug report: #634

Patches

For everyone seeking to get gala working with mutter 3.3x, I just built some AIO patches that group everything.
Here are the steps in order to get everything working properly:

Required mutter patches

Mutter needs to be patched (until the patch is merged upstream: https://gitlab.gnome.org/GNOME/mutter/commit/bd7704f9e17e9554ad663386ef4fce1e16a56f08)

Required gala patches

Single AIO patch that fix most of it: https://gist.github.com/Tireg/f6e13bd66c0234234c94ca4b330bf887

Optional patches

Warning: This patches requires using the above gala patch.

In order to backport support for reorder workspace, we need to patch mutter with the following patch (tested with mutter 3.32, unnecessary since mutter 3.34): https://gist.github.com/Tireg/49b5efc9db4a79232e093452a0d29759
This also requires patching the current gala code: https://gist.github.com/Tireg/f5513ad7693e17dfddcf2f920dc8785f

…instead of keeping at least the last workspace

tintou force-pushed the wip/mutter-3.3x branch 2 times, most recently from 0926bde to 249fa14 Compare June 25, 2019 16:56

donadigo previously approved these changes Jul 3, 2019

View reviewed changes

donadigo mentioned this pull request Jul 4, 2019

Add ability to reorder workspaces #464

Merged

alex285 mentioned this pull request Jul 11, 2019

With Mutter new API | undefined symbol: meta_compositor_flash_screen #306

Closed

tintou dismissed donadigo’s stale review via 901195f October 10, 2019 14:36

tintou force-pushed the wip/mutter-3.3x branch 2 times, most recently from 901195f to 4a1c17c Compare October 10, 2019 15:39

worldofpeace mentioned this pull request Oct 30, 2019

Adapt to the latest Mutter API elementary/greeter#377

Merged

ricotz and others added 3 commits October 31, 2019 10:04

Add support for mutter >= 3.29.4

7989e93

Add support for mutter >= 3.31.2

65bc5c8

Adapt to the latest Mutter API

286bbf4

Add support for libmutter-6

ca0ed9f

tintou force-pushed the wip/mutter-3.3x branch from ef7fac2 to ca0ed9f Compare October 31, 2019 09:06

danirabbit requested a review from donadigo October 31, 2019 19:17

donadigo approved these changes Oct 31, 2019

View reviewed changes

donadigo merged commit 0f0724c into master Oct 31, 2019

donadigo deleted the wip/mutter-3.3x branch October 31, 2019 21:22

Tireg mentioned this pull request Nov 8, 2019

Gala crash on startup with mutter 3.3x #634

Closed

3 tasks

Tireg referenced this pull request Nov 8, 2019

Fix Gala.WorkspaceManager.cleanup method which deletes all workspace …

b9f9ff6

…instead of keeping at least the last workspace

Tireg referenced this pull request Nov 8, 2019

Add missing manager.workspace_reordered callback for Mutter 3.34

a86d20f

Tireg mentioned this pull request Nov 8, 2019

fails to compile against latest mutter (3.29.4+) #303

Closed

This was referenced Nov 12, 2019

Keyboard shortcuts and media keys broken with gnome-settings-daemon 3.32 #518

Closed

mutter 3.34: windows not drawn in Windows Overview or Multitasking view #637

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adapt to mutter 3.33 #566

Adapt to mutter 3.33 #566

tintou commented Jun 25, 2019

donadigo left a comment

worldofpeace commented Jul 4, 2019 •

edited

Loading

Dirli commented Jul 5, 2019

alucryd commented Jul 11, 2019

worldofpeace commented Jul 12, 2019 •

edited

Loading

alucryd commented Jul 12, 2019

worldofpeace commented Jul 12, 2019

decathorpe commented Sep 10, 2019

decathorpe commented Oct 26, 2019

decathorpe commented Oct 26, 2019

Dirli commented Oct 26, 2019

decathorpe commented Oct 29, 2019

decathorpe commented Oct 29, 2019

worldofpeace commented Oct 29, 2019

decathorpe commented Oct 29, 2019

decathorpe commented Oct 30, 2019

decathorpe commented Oct 30, 2019

worldofpeace commented Oct 30, 2019 •

edited

Loading

worldofpeace commented Oct 30, 2019

donadigo left a comment

Dirli commented Nov 2, 2019 •

edited

Loading

worldofpeace commented Nov 2, 2019

Dirli commented Nov 3, 2019 •

edited

Loading

tintou commented Nov 3, 2019

worldofpeace commented Nov 3, 2019

worldofpeace commented Nov 3, 2019

Dirli commented Nov 3, 2019

tintou commented Nov 3, 2019

Tireg commented Nov 4, 2019 •

edited

Loading

Tireg commented Nov 7, 2019 •

edited

Loading

Tireg commented Nov 8, 2019 •

edited

Loading

Adapt to mutter 3.33 #566

Adapt to mutter 3.33 #566

Conversation

tintou commented Jun 25, 2019

donadigo left a comment

Choose a reason for hiding this comment

worldofpeace commented Jul 4, 2019 • edited Loading

Dirli commented Jul 5, 2019

WindowManager.vala ( public WindowManagerGala () ):

alucryd commented Jul 11, 2019

worldofpeace commented Jul 12, 2019 • edited Loading

alucryd commented Jul 12, 2019

worldofpeace commented Jul 12, 2019

decathorpe commented Sep 10, 2019

decathorpe commented Oct 26, 2019

decathorpe commented Oct 26, 2019

Dirli commented Oct 26, 2019

decathorpe commented Oct 29, 2019

decathorpe commented Oct 29, 2019

worldofpeace commented Oct 29, 2019

decathorpe commented Oct 29, 2019

decathorpe commented Oct 30, 2019

decathorpe commented Oct 30, 2019

worldofpeace commented Oct 30, 2019 • edited Loading

worldofpeace commented Oct 30, 2019

donadigo left a comment

Choose a reason for hiding this comment

Dirli commented Nov 2, 2019 • edited Loading

worldofpeace commented Nov 2, 2019

Dirli commented Nov 3, 2019 • edited Loading

tintou commented Nov 3, 2019

worldofpeace commented Nov 3, 2019

worldofpeace commented Nov 3, 2019

Dirli commented Nov 3, 2019

tintou commented Nov 3, 2019

Tireg commented Nov 4, 2019 • edited Loading

Required mutter patches:

Required Gala patches

Optionnal patches

Other bugs

Remove workspace bug

Edit

Tireg commented Nov 7, 2019 • edited Loading

Tireg commented Nov 8, 2019 • edited Loading

Patches

Required mutter patches

Required gala patches

Optional patches

worldofpeace commented Jul 4, 2019 •

edited

Loading

worldofpeace commented Jul 12, 2019 •

edited

Loading

worldofpeace commented Oct 30, 2019 •

edited

Loading

Dirli commented Nov 2, 2019 •

edited

Loading

Dirli commented Nov 3, 2019 •

edited

Loading

Tireg commented Nov 4, 2019 •

edited

Loading

Tireg commented Nov 7, 2019 •

edited

Loading

Tireg commented Nov 8, 2019 •

edited

Loading