Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with latest Vala 0.56.x #656

Closed
wants to merge 1 commit into from
Closed

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Aug 25, 2023

Previously #637. With vala@bac7c570 the failure is now on 0.56.x as well.

../lib/Widgets/Utils.vala:269.38-269.45: error: Argument 1: Cannot convert from `unowned uint8[]' to `unowned string'
  269 |         css_provider.load_from_data (css.data);
      |                                      ^~~~~~~~  
../lib/Widgets/Utils.vala:269.9-269.46: error: 1 missing arguments for `void Gtk.CssProvider.load_from_data (string, ssize_t)'
  269 |         css_provider.load_from_data (css.data);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 

(CI failure does not seem to be related?)

@tintou
Copy link
Member

tintou commented Aug 25, 2023

Let's wait for Vala upstream to clarify on this breakage https://gitlab.gnome.org/GNOME/vala/-/issues/1478

@tintou
Copy link
Member

tintou commented Aug 25, 2023

This will be fixed in next Vala 0.56.x version (see https://gitlab.gnome.org/GNOME/vala/-/commit/8895fdbf2fa1ece975110e6555cbb36692dc4096 )

@tintou tintou closed this Aug 25, 2023
@tintou tintou deleted the bobby285271/fix-build branch August 25, 2023 13:05
@bobby285271
Copy link
Member Author

Looks like the fix is applied to 0.58 as well: https://gitlab.gnome.org/GNOME/vala/-/issues/1478#note_1827790 so we probably want to revert #637?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants