Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with newer Vala #637

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Fix build with newer Vala #637

merged 1 commit into from
Mar 3, 2023

Conversation

alice-mkh
Copy link
Contributor

Gtk.CssProvider.load_from_data() takes a string instead of uint8[] now.

@alice-mkh
Fix build with newer Vala
a20281d 
Gtk.CssProvider.load_from_data() takes a string instead of uint8[] now.
@danirabbit danirabbit requested a review from tintou March 3, 2023 16:59
@tintou tintou merged commit 9065ac6 into main Mar 3, 2023
@tintou tintou deleted the wip/exalm/vala058 branch March 3, 2023 17:07
@bobby285271 bobby285271 mentioned this pull request Aug 25, 2023
Closed
bobby285271 pushed a commit that referenced this pull request Sep 9, 2023
@mcatanzaro
Revert "Fix build with newer Vala (#637)" (#659)
b86e04d 
This reverts commit 9065ac6.

Vala has reverted the API break that necessitated this change, and now
we cannot build with newer Vala again.

Fixes #658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintou tintou tintou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alice-mkh @tintou