Skip to content
This repository has been archived by the owner on May 28, 2023. It is now read-only.

npm install fails on Travis #755

Closed
2 of 3 tasks
dar5hak opened this issue Oct 21, 2019 · 4 comments · Fixed by #757
Closed
2 of 3 tasks

npm install fails on Travis #755

dar5hak opened this issue Oct 21, 2019 · 4 comments · Fixed by #757
Labels

Comments

@dar5hak
Copy link
Sponsor Contributor

dar5hak commented Oct 21, 2019

Prerequisites

  • I have searched open and closed issues for duplicates.

Describe the bug

While trying to install @elementaryos/houston, node-gyp encounters an error related to nodegit package.

To Reproduce

Steps to reproduce the behavior:

  1. Push to a branch on an AppCenter-enabled repo so that the build is triggered.
  2. Go to the Travis build log.
  3. See error: The command "npm i -g @elementaryos/houston" failed and exited with 1 during .

Expected behavior

The build installs the package as usual and runs the tests.

Screenshots or screen recordings

image

Logs

See this build for complete error stack and more details:
https://travis-ci.org/elfenware/badger/builds/600805745

Platform Information

  • I'm using the latest version from git that I've manually compiled
  • I'm using the latest released stable version

Additional context

NA

@dar5hak
Copy link
Sponsor Contributor Author

dar5hak commented Oct 21, 2019

One difference I noticed is how it tries to fetch nodegit. In my previous successful builds, it fetched prebuilt binaries of nodegit and used those. In this failed build, it couldn't fetch those, so it tried to compile it locally, which didn't work.

Older, successful build:
image

Current, failed build:
image

@gamerlv
Copy link
Member

gamerlv commented Oct 21, 2019

I've checked over the log you linked. The root cause is the new nodejs LTS version, v12, that was released on the 21st of this month. In your .travis.yml file you specified you want your test to run on the latest. Previous tests where run with nodejs LTS v10.

Houston-cli has a dependency on nodegit as you see in the error, currently we are using version 0.24. Support for nodejs v12 was only added to nodegit as of version 0.26 (Initial support in 0.25 but stabilized in the later version)

For solutions to get your tests green again you could lower the nodejs version back to LTS v10 or wait for us to release an update to houston-cli.

@dar5hak
Copy link
Sponsor Contributor Author

dar5hak commented Oct 22, 2019

@gamerlv Ah, that makes sense. Thank you, I'll wait for the update.

@btkostner
Copy link
Contributor

🎉 This issue has been resolved in version 6.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants