Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Portuguese Translation #132

Merged
merged 7 commits into from
Nov 4, 2019
Merged

Update Portuguese Translation #132

merged 7 commits into from
Nov 4, 2019

Conversation

hugok79
Copy link
Contributor

@hugok79 hugok79 commented Nov 3, 2019

Update Portuguese translation. I've also create the Portuguese .po file in extra folder and completed the translation.
These .po files are for the Portuguese (pt) Portugal Language. Brazilian Portuguese should create .po files in (pt_BR)

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you need to add pt to https://github.com/hugok79/monitor/blob/master/po/extra/LINGUAS so that we can update the Portuguese translation file with other translation files.

po/pt.po Outdated
"Language-Team: \n"
"Language: pt\n"
"Language: pt_PT\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Language: pt_PT\n"
"Language: pt\n"

I guess lefting pt is fine, for example: https://github.com/elementary/sideload/blob/7fecf730d716f0fab41c5ddf35d317280a017c74/po/extra/pt.po#L15

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake editing the po file in Poedit.
Done. Thanks

po/pt.po Outdated

#: src/Widgets/Headerbar.vala:62
msgid "Start in background:"
msgstr ""
msgstr "Inicia em segundo plano"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand Portuguese, but is it intentional that the trailing colon is missing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. I forgot to put the colon. (I did not validate when editing the the po file in Poedit so I didn't see that mistake).
Done

po/pt.po Outdated Show resolved Hide resolved
@hugok79
Copy link
Contributor Author

hugok79 commented Nov 4, 2019

Why the Travis CI build error???

@ryonakano
Copy link
Contributor

That seems like a Houston issue, so it's fine.

@stsdc
Copy link
Member

stsdc commented Nov 4, 2019

@hugok79 Is it ready to merge?

@hugok79
Copy link
Contributor Author

hugok79 commented Nov 4, 2019

Yes, it's ready.

@stsdc stsdc changed the base branch from master to unstable November 4, 2019 20:31
@stsdc stsdc merged commit 4784bc4 into elementary:unstable Nov 4, 2019
@stsdc
Copy link
Member

stsdc commented Nov 4, 2019

Thanks @hugok79 ❤️ !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants