Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inkscape's Distributions Icons #911

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Fatih20
Copy link
Contributor

@Fatih20 Fatih20 commented Jul 4, 2020

Fixes #763 and then some. It also add `distribute-graph and symbolic icons of them.

This is how the icons look under elementary's light theme
image
This is how the icons look under elementary's dark theme
image
This is how the symbolic icons look under elementary's light theme
image
This is how the symbolic icons look under elementary's dark theme
image

There is some things that is still in the file that I use in the design process of these icons. I'll be cleaning them up once these are finalized and approved.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on these!

distribute-graph looks great. Nice work here.

I think distribute-randomize might need more objects to make it clearer. With only three objects it's difficult to see that these are placed randomly. I can see why the original icon uses twice as many objects.

It seems like it might be important for the objects in distribute-unclump to be different sizes so you can illustrate that it equalizes edge-to-edge distances and not center-to-center

@Fatih20
Copy link
Contributor Author

Fatih20 commented Jul 9, 2020

This is how the icons look under elementary's light theme
image
This is how the icons look under elementary's dark theme
image
This is how the symbolic icons look under elementary's light theme
image
This is how the symbolic icons look under elementary's dark theme
image

There is some things that is still in the file that I use in the design process of these icons. I'll be cleaning them up once these are finalized and approved.

@Fatih20
Copy link
Contributor Author

Fatih20 commented Jul 16, 2020

Is there any more revision you'd like to see or is this done? @danrabbit

@Fatih20
Copy link
Contributor Author

Fatih20 commented Jul 16, 2020

This is how the icons look under elementary's light theme
image
This is how the icons look under elementary's dark theme
image

Symbolic icons is unchanged. Refer to previous screenshots.

There is some things that is still in the file that I use in the design process of these icons. I'll be cleaning them up once these are finalized and approved.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for making changes here. I feel like we're getting really close.

I think distribute-randomize might still look too evenly distributed. You'll notice in the default Inkscape icon that some objects are clumped closer together than others.

In looking at the original icon for distribute-unclump it seems like having some of the objects be rectangles is important. Remember we're trying to show that these will be spaced by edge distance, not center distance. So having an object where those are nearly the same makes it hard to see that distinction.

@Fatih20
Copy link
Contributor Author

Fatih20 commented Jul 16, 2020

Hey thanks for making changes here. I feel like we're getting really close.

I think distribute-randomize might still look too evenly distributed. You'll notice in the default Inkscape icon that some objects are clumped closer together than others.

In looking at the original icon for distribute-unclump it seems like having some of the objects be rectangles is important. Remember we're trying to show that these will be spaced by edge distance, not center distance. So having an object where those are nearly the same makes it hard to see that distinction.

Hmm, you're right. I'll be working on it.

@Fatih20
Copy link
Contributor Author

Fatih20 commented Jul 18, 2020

Here they are. I changed both of the square at the bottom and the top to a rectangle in distribute-unclump and made the squares in distribute-randomize less evenly distributed. What do you think? I'll pixel fit for the 16 and symbolic if you think this is good. @danrabbit
image
image

@danirabbit
Copy link
Member

The distribution on the randomize icon looks a lot better. Just be sure you align items to the pixel grid. Make sure highlight strokes are 1px wide

On the unclump icon, it would probably be better to not have these rectangles both in landscape orientation. One in portrait orientation would probably help. And also, it's pretty clear that these are no longer equidistant from each other's edges :)

@Fatih20
Copy link
Contributor Author

Fatih20 commented Jul 21, 2020

Here's how it looked like now.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distribute object icons
2 participants