Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Refresh #680

Merged
merged 18 commits into from
Sep 23, 2021
Merged

Manual Refresh #680

merged 18 commits into from
Sep 23, 2021

Conversation

marbetschar
Copy link
Member

@marbetschar marbetschar commented Sep 5, 2021

This PR add the ability to manually trigger a refresh and fetch messages from backend:

Screenshot from 2021-09-05 14-16-27

However, two Gtk issues remain with the current implementation - wasn't able to figure out what's going on here:

  • The refresh button seems to be active and the default action whenever Mail is started. How to change this? setting can_focus = false fixed this
  • The animation of the state change seems to be started quite late, not right on click. How to improve? yield ..async ... fixed this - thanks @dbhowell!

And one UX question: I'd love to use <Control>R for refresh/reload - but it's already used for Reply. Thoughts?

@marbetschar marbetschar requested a review from a team September 5, 2021 12:24
@marbetschar marbetschar added Help Wanted Needs Design Waiting for input from the UX team labels Sep 7, 2021
@dbhowell

This comment has been minimized.

@marbetschar

This comment has been minimized.

@marbetschar

This comment has been minimized.

@marbetschar marbetschar marked this pull request as ready for review September 21, 2021 10:28
@marbetschar marbetschar removed Needs Design Waiting for input from the UX team Help Wanted labels Sep 21, 2021
src/HeaderBar.vala Outdated Show resolved Hide resolved
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably look at default widget focus in a follow up branch, but I think it makes sense to get this functionality in :)

@danirabbit danirabbit enabled auto-merge (squash) September 23, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants