Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Handle dialog action area margin #839

Merged
merged 7 commits into from
Oct 14, 2020
Merged

Windows: Handle dialog action area margin #839

merged 7 commits into from
Oct 14, 2020

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Sep 28, 2020 •
edited

Fixes #281

This is gonna break a bunch of stuff, but might as well get it over with.

Goes with elementary/granite#374

@danirabbit danirabbit added this to Confirmed in Stylesheet Rewrite/Redesign via automation Sep 28, 2020
@danirabbit danirabbit added this to In progress in Dialog Action Areas via automation Sep 28, 2020
@danirabbit danirabbit moved this from Confirmed to In Progress in Stylesheet Rewrite/Redesign Sep 28, 2020
@danirabbit danirabbit mentioned this pull request Sep 29, 2020
Merged
4 tasks
cassidyjames
cassidyjames approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this breaks dialog spacing in a bunch of places. 😛 But it looks good with the linked Granite branch.

@cassidyjames cassidyjames merged commit ee99198 into master Oct 14, 2020
Stylesheet Rewrite/Redesign automation moved this from In Progress to Fix Committed Oct 14, 2020
Dialog Action Areas automation moved this from In progress to Done Oct 14, 2020
@cassidyjames cassidyjames deleted the dialog-spacing branch October 14, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassidyjames cassidyjames cassidyjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Dialog Action Areas
  
Done
Stylesheet Rewrite/Redesign
  
Fix Committed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set dialog action area margin
2 participants
@danirabbit @cassidyjames