Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make update button optional #97

Closed

Conversation

worldofpeace
Copy link
Contributor

In environments that don't have Appcenter
or will never have a use for it this button
would be confusing.

In environments that don't have Appcenter
or will never have a use for it this button
would be confusing.
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a compile-time option how about checking to see if AppCenter is installed at construction time?

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Aug 5, 2019

Huh, I thought a compile time option was fine.
Checking if it's installed might be less intrusive since you don't have to do any build configuration. I'm not sure I'd make that change though.

@danirabbit
Copy link
Member

superseded by #98

@danirabbit danirabbit closed this Aug 15, 2019
@worldofpeace worldofpeace deleted the optional-update-button branch August 15, 2019 22:45
@worldofpeace
Copy link
Contributor Author

superseded by #98

💖 Another downstream patch gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants