Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plug: check for AppCenter before creating updates button #98

Merged
merged 3 commits into from Aug 15, 2019

Conversation

danirabbit
Copy link
Member

Alternative to #97 that checks for the existence of AppCenter before creating the update button

worldofpeace
worldofpeace previously approved these changes Aug 5, 2019
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Perhaps a comment could be helpful here.

Copy link
Contributor

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, when I uninstall AppCenter and run this, this works. However, when I reinstall AppCenter, I can't get the button to show back up.

@cassidyjames
Copy link
Contributor

@danrabbit for some reason I'm still not getting an updates button after reinstalling AppCenter from the repos, rebooting, etc.

src/Plug.vala Outdated Show resolved Hide resolved
} catch (Error e) {
warning (e.message);
}
appcenter_info.launch_action ("ShowUpdates", new GLib.AppLaunchContext ());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that's a thing 🤯️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that an approve :p

Copy link
Contributor

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually works now!

@cassidyjames cassidyjames merged commit 6ff63b8 into master Aug 15, 2019
@cassidyjames cassidyjames deleted the plug-check-for-appcenter branch August 15, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants