New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Power Profile Management #192
Enable Power Profile Management #192
Conversation
…board-plug-power into power_mode_settings
@SubhadeepJasu regarding the daemon, it looks like the upstream solution is https://gitlab.freedesktop.org/hadess/power-profiles-daemon. Would it be possible to depend on that? |
I would wanna. They are providing manual power management. Not sure if they want to do automatic as well. If not then we have to do something about that. |
They are providing two use cases: powersaver and performance. I think for the 3rd use case we can merge a part of my code about automatic mode into either the indicator or settings daemon. That will allow us to use freedesktop ppm along with my logic for an auto mode. |
@SubhadeepJasu it would be worth chatting with upstream first before doing our own automatic mode downstream; less code to maintain ourselves is almost always good—plus other desktops can benefit from our contributions. |
I'll open an issue on their repo to discuss the need for an automatic mode and possible ways to pull it off. |
I have an open issue on their repo: https://gitlab.freedesktop.org/hadess/power-profiles-daemon/-/issues/42 |
Nope, they recommend doing this on our end. An automatic mode upstream is out of scope. According to the maintainer, the whole battery, load and thermal monitoring + automatic/intelligent scaling is something that the DE should implement. Also He said that its not something that can be called "upstream" :-/ What do you suggest? |
@SubhadeepJasu it sounds like to start we would offer Power Saver, Balanced, and High Performance modes and that would be in line with the power-profiles-daemon. In the future we could offer smarter configuration and switching of modes, like when someone plugs in or unplugs power, when the battery is low, etc. But for now just being able to configure the power-profiles-daemon sounds like a useful improvement.
I think they just meant that implementing it in that project whether upstream or in a fork didn't make sense, and doesn't realize that we're considering the daemon an upstream project. Just a miscommunication. 😄 |
Gotcha |
This has to wait, for some time. Because I got some urgent work this week. |
I would add a label to the buttons. |
@SubhadeepJasu It should be thought about how to integrate it into the new design #194 |
It only applies to the behavior section. I would suggest merging that pr first which would make it easier to merge this one appropriately. |
Noting here that it looks like GNOME Settings Daemon includes a setting for automatically enabling power saving profile on low battery at Targeting this also to OS 7 since we have power profiles daemon installed by default now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does the thing, so I'm inclined to merge and iterate while we're at the beginning of the cycle. Nice work!
Awesome! We can later have a automatic toggle or a fourth button for it based on what the designers decide. |
Enable Automatic/Manual power management from power switchboard plug.
Make automatic power management logic(Out of scope for now, but it can be implemented later)