Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/Hide job queue according to privacy setting #161

Closed
wants to merge 1 commit into from

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jun 2, 2022

Fixes #40

Also moves construction code into construct {} clause and uses Object-style creation.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I don't have a printer to test, but reading through this seems like kind of a false privacy. I don't think the issue is whether the queue is shown while privacy mode is enabled, but whether jobs are saved in the queue after they're printed. Correct me if I'm wrong here, but wouldn't all the previous jobs show in the queue again if someone were to go change the remember files setting?

I think a case for privacy here is for example you're working on a shared computer and you go turn on privacy mode, print something sensitive, and then turn privacy mode back off so that there's no record of you having made that print.

Or perhaps you just leave privacy mode on all the time, but if someone where to use the computer and turn privacy mode off, you'd want to make sure that this means the print history queue is still empty and not that the queue is now revealed.

@jeremypw
Copy link
Collaborator Author

jeremypw commented Jun 2, 2022

@danrabbit Good point. I'll look into whether it is possible to clear the queue at the system level as well (and not save new jobs to it) when privacy is on.

@jeremypw jeremypw marked this pull request as draft June 2, 2022 18:53
@jeremypw
Copy link
Collaborator Author

jeremypw commented Jun 2, 2022

There is a "Clear History" button in the Privacy settings but not sure whether this clears the job queue. I'll check.

@jeremypw
Copy link
Collaborator Author

jeremypw commented Jun 3, 2022

"Clear History" in the Privacy plug does not clear the printer queue. I have raised on issue regarding this. I have also pushed a PR for a button that clears the queue.

@jeremypw
Copy link
Collaborator Author

jeremypw commented Jun 3, 2022

If the Privacy plug offers the ability to clear the printer queue then maybe this PR will not be needed.

@jeremypw
Copy link
Collaborator Author

CLosing as outdated. Maybe better implemented in the privacy plug anyway.

@jeremypw jeremypw closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] Toggle to enable/disable printed jobs history
2 participants