Implement gnome-terminal style -x (--) flag. #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2019 18:45
# Conflicts fixed in: # src/MainWindow.vala
Philip-Scott
suggested changes
Aug 24, 2019
added 5 commits
August 25, 2019 11:29
Philip-Scott
previously approved these changes
Aug 28, 2019
There was a problem hiding this comment.
Code wise it looks good to me, but I haven't had a chance to compile and test it (and won't be able to this week) If you can get someone else to test it as well that would be great :) but I'm removing my "needs changes" to not be a blocker.
If no one else checks it by next week, I'll give it a look once I'm back home :)
|
@Philip-Scott OK, thanks for the review - I'll not merge for now. |
# Conflicts fixed in: # src/Application.vala
|
@Philip-Scott Any chance of a re-review? :-) |
Merged
tintou
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #395 (hopefully)
Implements a flag (-x or --) that causes the remainder of the line to be treated as a command in its own right, to be passed to a new terminal, without requiring quotes. This is intended to match the behaviour of gnome-terminal. It allows more complex commands to be executed (including their own flags). The existing
-eflag only allows a single argument per command so complex commands need quoting.It may be advisable to define strings that cause the command building to end - advice required.