-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create PlaybackManager #319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tintou
reviewed
Dec 10, 2022
tintou
reviewed
Dec 10, 2022
Co-authored-by: Corentin Noël <corentin@elementary.io>
tintou
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently things like playback state, actions, the queue, etc are all stored across different widget-based classes. It's a huge mess with classes having to reach across each other and keep track of their instances to do anything.
This does the least to create a PlaybackManager class with a single instance where we can eventually store the queue, take actions, etc in a way that doesn't depend on the UI and doesn't involve passing objects around between classes etc
It's obviously kind of garbage right now because it doesn't actually hold the queue or the playbin, but hopefully it makes sense how eventually we'll get there and how even just this stops some of the reaching into other classes. Especially some obviously ridiculous lines like:
((Audience.Window)((Gtk.Application) Application.get_default ()).active_window).player_page.set_subtitle (external_subtitle_file.get_uri ());