Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode the filename of the iso #2484

Closed
1 task done
ryonakano opened this issue Jul 11, 2020 · 2 comments · Fixed by #2579
Closed
1 task done

Don't hardcode the filename of the iso #2484

ryonakano opened this issue Jul 11, 2020 · 2 comments · Fixed by #2579

Comments

@ryonakano
Copy link
Sponsor Contributor

Prerequisites

  • I have searched open and closed issues for duplicates.

Feature

Is your feature request related to a problem? Please describe.
Whenever a new iso file of elementary OS is uploaded, the name of is file changes. And, because the paragraph in the "Boot Errors" section in the installation instruction page includes it, the whole paragraph gets updated. I feel a little troublesome for this, because my translation for the whole paragraph is removed, although the other portion of the paragraph is not changed at all:

Screenshot from 2020-07-12 06-22-41

Describe the solution you'd like
The name of an iso file is constant among all languages and will not be translated. So, I guess it should be replaced with a kind of a format specifier (I don't understand PHP, but I mean something like %s in Vala or {#name} in Ruby).

By doing this, the whole paragraph should become constant regardless of filenames:

- …, right click on the ISO file in Finder, and select "Burn elementaryos-5.1-stable.20200706.iso to Disc".
+ …, right click on the ISO file in Finder, and select "Burn {#filename} to Disc". 

In this way, translators no longer have to renew their translation each time when the iso file is updated.

Existing work
N/A

Describe alternatives you've considered
N/A

Additional context
N/A

@lewisgoddard lewisgoddard added this to the Terrific Translation milestone Jul 12, 2020
@lewisgoddard
Copy link
Member

Those docs aren't written in PHP, they are in Markdown, which doesn't support this kind of behavior. That is why this hasn't been done until now. I otherwise agree that the installation doc changes monthly with releases at this point, which is quite undesirable.

@ElDarco
Copy link

ElDarco commented Oct 27, 2020

Those docs aren't written in PHP, they are in Markdown, which doesn't support this kind of behavior. That is why this hasn't been done until now. I otherwise agree that the installation doc changes monthly with releases at this point, which is quite undesirable.

Maybe make a console command that will replace text like {#name} in .md files with the desired value? You can run this command every release. I could write that. This would be my first commit to this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants