Indicator: Lookup io.elementary.notifications recursively #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs on SettingsSchemaSource get_default say ``` The returned source may actually consist of multiple schema sources from different directories, depending on which directories were given in `XDG_DATA_DIRS` and `GSETTINGS_SCHEMA_DIR`. For this reason, all lookups performed against the default source should probably be done recursively. ``` Without this in NixOS, it will always use gala notifications because recursion is required. It would be nice if any new code in Pantheon always works like this to support NixOS properly.
worldofpeace
added a commit
to worldofpeace/switchboard-plug-notifications
that referenced
this pull request
Apr 6, 2020
Similar motivation as elementary/wingpanel-indicator-notifications#110.
worldofpeace
added a commit
to worldofpeace/switchboard-plug-notifications
that referenced
this pull request
Apr 6, 2020
Similar motivation as elementary/wingpanel-indicator-notifications#110.
|
PR incoming for switchboard as well. |
worldofpeace
added a commit
to worldofpeace/switchboard-plug-notifications
that referenced
this pull request
Apr 6, 2020
Similar motivation as elementary/wingpanel-indicator-notifications#110.
worldofpeace
added a commit
to worldofpeace/switchboard-plug-notifications
that referenced
this pull request
Apr 6, 2020
Similar motivation as elementary/wingpanel-indicator-notifications#110.
This was referenced Apr 6, 2020
Merged
tintou
pushed a commit
to elementary/switchboard-plug-notifications
that referenced
this pull request
Apr 6, 2020
Similar motivation as elementary/wingpanel-indicator-notifications#110.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs on SettingsSchemaSource get_default say
Without this in NixOS, it will always use gala notifications
because recursion is required. It would be nice if any new code
in Pantheon always works like this to support NixOS properly.
I noticed this in elementary/notifications#62 (comment).