Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CSS and fix issues with shadows and struts #493

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Aug 9, 2023

Fixes #408

  • Use a single Application.css file instead of separate application.css and panel.css (In Gtk4 we can use Granite.init to load this automatically)
  • Set panel css name once instead of setting style class twice nested within itself
  • Update easing func
  • Remove a constants class for strings that are only used once
  • Fix drop shadow not rendering when translucent styles change (for example from a solid color to a busy wallpaper)

BEFORE

Screenshot from 2023-12-06 10 43 53
Screenshot from 2023-12-06 10 50 14

AFTER

Screenshot from 2023-12-06 10 42 33
Screenshot from 2023-12-06 10 49 27

@danirabbit danirabbit marked this pull request as ready for review August 11, 2023 18:36
@danirabbit danirabbit requested a review from a team August 11, 2023 18:36
@lenemter
Copy link
Member

lenemter commented Aug 12, 2023

This branch changed battery indicator color. Is this intentional?

image

@jeremypw
Copy link
Collaborator

jeremypw commented Dec 6, 2023

Closing as linked issues appears to be fixed.

@jeremypw jeremypw closed this Dec 6, 2023
@danirabbit
Copy link
Member Author

This still contains CSS fixes I'd like to get merged. I'll update the description here and address the review comment from Leo. Sorry for not updating sooner!

@danirabbit danirabbit reopened this Dec 6, 2023
@danirabbit
Copy link
Member Author

@lenemter fixed!

@danirabbit danirabbit merged commit 0fb4a14 into master Dec 6, 2023
4 checks passed
@danirabbit danirabbit deleted the danirabbit/css-cleanup branch December 6, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wingpanel has top gap when apps are snapped to left-half/right-half
4 participants